Groups > linux.kernel > #1451940

Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes
Date	2016-07-28 16:00 +0200
Message-ID	<rZU0V-70m-5@gated-at.bofh.it> (permalink)
References	<rXqJI-2G4-11@gated-at.bofh.it> <rXqTn-2Jr-5@gated-at.bofh.it> <rZp6O-3eN-5@gated-at.bofh.it> <rZCQp-3GO-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Andrew Morton <akpm@linux-foundation.org> writes:

> On Wed, 27 Jul 2016 14:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>> arch/powerpc/sysdev/fsl_rio.c:702:11: error: 'struct rio_mport' has no member named 'phy_type'
>> arch/powerpc/sysdev/fsl_rio.c:702:25: error: 'RIO_PHY_SERIAL' undeclared (first use in this function)
>
> I'll go out on a limb and assume it's this:
>
> --- a/arch/powerpc/sysdev/fsl_rio.c~powerpc-fsl_rio-apply-changes-for-rio-spec-rev-3-fix
> +++ a/arch/powerpc/sysdev/fsl_rio.c
> @@ -698,11 +698,6 @@ int fsl_rio_setup(struct platform_device
>  			RIO_INB_ATMU_REGS_PORT2_OFFSET));
>  
>  
> -		/* Set to receive any dist ID for serial RapidIO controller. */
> -		if (port->phy_type == RIO_PHY_SERIAL)
> -			out_be32((priv->regs_win
> -				+ RIO_ISR_AACR + i*0x80), RIO_ISR_AACR_AA);
> -

Yep, thanks.

Hopefully someone somewhere is testing this on powerpc, I don't have one
of those FSL boxes. But at least it will build now.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes Michael Ellerman <mpe@ellerman.id.au> - 2016-07-27 07:00 +0200
  RE: [PATCH 11/13] rapidio: modify for rev.3 specification changes "Wood, Barry" <Barry.Wood@idt.com> - 2016-07-27 12:40 +0200
  Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes Andrew Morton <akpm@linux-foundation.org> - 2016-07-27 21:40 +0200
    Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes Michael Ellerman <mpe@ellerman.id.au> - 2016-07-28 16:00 +0200

csiph-web