Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451624 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2016-07-28 04:10 +0200 |
| Last post | 2016-07-28 13:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() Wei Yongjun <weiyj.lk@gmail.com> - 2016-07-28 04:10 +0200
Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() Liviu Dudau <liviu.dudau@arm.com> - 2016-07-28 10:20 +0200
Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() Daniel Vetter <daniel@ffwll.ch> - 2016-07-28 13:10 +0200
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-07-28 04:10 +0200 |
| Subject | [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() |
| Message-ID | <rZIVQ-7X5-13@gated-at.bofh.it> |
There is a error message within devm_ioremap_resource
already, so remove the DRM_ERROR call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/gpu/drm/arm/malidp_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 4e61ea5..1160322 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
hwdev->regs = devm_ioremap_resource(dev, res);
- if (IS_ERR(hwdev->regs)) {
- DRM_ERROR("Failed to map control registers area\n");
+ if (IS_ERR(hwdev->regs))
return PTR_ERR(hwdev->regs);
- }
hwdev->pclk = devm_clk_get(dev, "pclk");
if (IS_ERR(hwdev->pclk))
[toc] | [next] | [standalone]
| From | Liviu Dudau <liviu.dudau@arm.com> |
|---|---|
| Date | 2016-07-28 10:20 +0200 |
| Subject | Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() |
| Message-ID | <rZOHU-3yL-23@gated-at.bofh.it> |
| In reply to | #1451624 |
On Thu, Jul 28, 2016 at 02:09:13AM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the DRM_ERROR call to avoid redundant
> error message.
Yeah, good catch!
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
Thanks for the cleanup!
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 4e61ea5..1160322 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> hwdev->regs = devm_ioremap_resource(dev, res);
> - if (IS_ERR(hwdev->regs)) {
> - DRM_ERROR("Failed to map control registers area\n");
> + if (IS_ERR(hwdev->regs))
> return PTR_ERR(hwdev->regs);
> - }
>
> hwdev->pclk = devm_clk_get(dev, "pclk");
> if (IS_ERR(hwdev->pclk))
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
[toc] | [prev] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2016-07-28 13:10 +0200 |
| Subject | Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() |
| Message-ID | <rZRmp-5r9-3@gated-at.bofh.it> |
| In reply to | #1451790 |
On Thu, Jul 28, 2016 at 09:11:43AM +0100, Liviu Dudau wrote:
> On Thu, Jul 28, 2016 at 02:09:13AM +0000, Wei Yongjun wrote:
> > There is a error message within devm_ioremap_resource
> > already, so remove the DRM_ERROR call to avoid redundant
> > error message.
>
> Yeah, good catch!
>
> >
> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>
> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
Applied to drm-misc, thanks.
-Daniel
>
>
> Thanks for the cleanup!
> Liviu
>
> > ---
> > drivers/gpu/drm/arm/malidp_drv.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> > index 4e61ea5..1160322 100644
> > --- a/drivers/gpu/drm/arm/malidp_drv.c
> > +++ b/drivers/gpu/drm/arm/malidp_drv.c
> > @@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev)
> >
> > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > hwdev->regs = devm_ioremap_resource(dev, res);
> > - if (IS_ERR(hwdev->regs)) {
> > - DRM_ERROR("Failed to map control registers area\n");
> > + if (IS_ERR(hwdev->regs))
> > return PTR_ERR(hwdev->regs);
> > - }
> >
> > hwdev->pclk = devm_clk_get(dev, "pclk");
> > if (IS_ERR(hwdev->pclk))
> >
>
> --
> ====================
> | I would like to |
> | fix the world, |
> | but they're not |
> | giving me the |
> \ source code! /
> ---------------
> ¯\_(ツ)_/¯
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web