Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451624

[PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind()

From Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups linux.kernel
Subject [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind()
Date 2016-07-28 04:10 +0200
Message-ID <rZIVQ-7X5-13@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


There is a error message within devm_ioremap_resource
already, so remove the DRM_ERROR call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
 drivers/gpu/drm/arm/malidp_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 4e61ea5..1160322 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	hwdev->regs = devm_ioremap_resource(dev, res);
-	if (IS_ERR(hwdev->regs)) {
-		DRM_ERROR("Failed to map control registers area\n");
+	if (IS_ERR(hwdev->regs))
 		return PTR_ERR(hwdev->regs);
-	}
 
 	hwdev->pclk = devm_clk_get(dev, "pclk");
 	if (IS_ERR(hwdev->pclk))

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() Wei Yongjun <weiyj.lk@gmail.com> - 2016-07-28 04:10 +0200
  Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in  malidp_bind() Liviu Dudau <liviu.dudau@arm.com> - 2016-07-28 10:20 +0200
    Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in  malidp_bind() Daniel Vetter <daniel@ffwll.ch> - 2016-07-28 13:10 +0200

csiph-web