Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1449796 > unrolled thread

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

Started byJens Axboe <axboe@kernel.dk>
First post2016-07-25 22:50 +0200
Last post2016-07-25 22:50 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open Jens Axboe <axboe@kernel.dk> - 2016-07-25 22:50 +0200

#1449796 — Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

FromJens Axboe <axboe@kernel.dk>
Date2016-07-25 22:50 +0200
SubjectRe: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open
Message-ID<rYUZ4-Lt-21@gated-at.bofh.it>
On 06/30/2016 05:18 AM, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> Commit 09954bad4 ("floppy: refactor open() flags handling"), as a
> side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that
> this is being used setfdprm userspace for ioctl-only open().
>
> Reintroduce back the original behavior wrt !(FMODE_READ|FMODE_WRITE)
> modes, while still keeping the original O_NDELAY bug fixed.
>
> Cc: stable@vger.kernel.org # v4.5+
> Reported-by: Wim Osterholt <wim@djo.tudelft.nl>
> Tested-by: Wim Osterholt <wim@djo.tudelft.nl>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Added for this series, thanks.

-- 
Jens Axboe

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web