Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open
Date	2016-07-25 22:50 +0200
Message-ID	<rYUZ4-Lt-21@gated-at.bofh.it> (permalink)
References	(4 earlier) <rKj3j-34D-15@gated-at.bofh.it> <rKjPH-3AP-15@gated-at.bofh.it> <rKrNg-7o-29@gated-at.bofh.it> <rKAnw-5uL-21@gated-at.bofh.it> <rPIaK-to-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/30/2016 05:18 AM, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> Commit 09954bad4 ("floppy: refactor open() flags handling"), as a
> side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that
> this is being used setfdprm userspace for ioctl-only open().
>
> Reintroduce back the original behavior wrt !(FMODE_READ|FMODE_WRITE)
> modes, while still keeping the original O_NDELAY bug fixed.
>
> Cc: stable@vger.kernel.org # v4.5+
> Reported-by: Wim Osterholt <wim@djo.tudelft.nl>
> Tested-by: Wim Osterholt <wim@djo.tudelft.nl>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Added for this series, thanks.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open Jens Axboe <axboe@kernel.dk> - 2016-07-25 22:50 +0200

csiph-web