Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1449563 > unrolled thread

xfs_icache.c:1298]: (style) Redundant condition

Started byDavid Binderman <linuxdev.baldrick@gmail.com>
First post2016-07-25 17:20 +0200
Last post2016-08-01 08:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

Contents

  xfs_icache.c:1298]: (style) Redundant condition David Binderman <linuxdev.baldrick@gmail.com> - 2016-07-25 17:20 +0200
    Re: xfs_icache.c:1298]: (style) Redundant condition Christoph Hellwig <hch@infradead.org> - 2016-08-01 08:40 +0200

#1449563 — xfs_icache.c:1298]: (style) Redundant condition

FromDavid Binderman <linuxdev.baldrick@gmail.com>
Date2016-07-25 17:20 +0200
Subjectxfs_icache.c:1298]: (style) Redundant condition
Message-ID<rYPPH-6aR-7@gated-at.bofh.it>
Hello there,

linux-4.7/fs/xfs/xfs_icache.c:1298]: (style) Redundant condition:
eofb. '!eofb || (eofb && eofb.eof_scan_owner!=0)' is equivalent to
'!eofb || eofb.eof_scan_owner!=0'

Source code is

   ASSERT(!eofb || (eofb && eofb->eof_scan_owner != 0));

Maybe better code

   ASSERT(!eofb || (eofb->eof_scan_owner != 0));

Regards

David Binderman

[toc] | [next] | [standalone]

#1453005

FromChristoph Hellwig <hch@infradead.org>
Date2016-08-01 08:40 +0200
Message-ID<s1f3j-2I4-1@gated-at.bofh.it>
In reply to#1449563
On Mon, Jul 25, 2016 at 04:13:28PM +0100, David Binderman wrote:
> Hello there,
> 
> linux-4.7/fs/xfs/xfs_icache.c:1298]: (style) Redundant condition:
> eofb. '!eofb || (eofb && eofb.eof_scan_owner!=0)' is equivalent to
> '!eofb || eofb.eof_scan_owner!=0'
> 
> Source code is
> 
>    ASSERT(!eofb || (eofb && eofb->eof_scan_owner != 0));
> 
> Maybe better code
> 
>    ASSERT(!eofb || (eofb->eof_scan_owner != 0));

Yes, that would be better.  But it's probably not worth changing
existing code just for that.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web