xfs_icache.c:1298]: (style) Redundant condition

From	David Binderman <linuxdev.baldrick@gmail.com>
Newsgroups	linux.kernel
Subject	xfs_icache.c:1298]: (style) Redundant condition
Date	2016-07-25 17:20 +0200
Message-ID	<rYPPH-6aR-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello there,

linux-4.7/fs/xfs/xfs_icache.c:1298]: (style) Redundant condition:
eofb. '!eofb || (eofb && eofb.eof_scan_owner!=0)' is equivalent to
'!eofb || eofb.eof_scan_owner!=0'

Source code is

   ASSERT(!eofb || (eofb && eofb->eof_scan_owner != 0));

Maybe better code

   ASSERT(!eofb || (eofb->eof_scan_owner != 0));

Regards

David Binderman

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

xfs_icache.c:1298]: (style) Redundant condition David Binderman <linuxdev.baldrick@gmail.com> - 2016-07-25 17:20 +0200
  Re: xfs_icache.c:1298]: (style) Redundant condition Christoph Hellwig <hch@infradead.org> - 2016-08-01 08:40 +0200

csiph-web