Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1448062 > unrolled thread
| Started by | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| First post | 2016-07-21 20:50 +0200 |
| Last post | 2016-07-21 21:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-07-21 20:50 +0200
Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*() Tom Yan <tom.ty89@gmail.com> - 2016-07-21 21:00 +0200
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-07-21 20:50 +0200 |
| Subject | Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*() |
| Message-ID | <rXrcJ-2T6-1@gated-at.bofh.it> |
Hello.
On 07/21/2016 09:41 PM, tom.ty89@gmail.com wrote:
> From: Tom Yan <tom.ty89@gmail.com>
>
> 1. Removed a repeated bit masking in ata_mselect_control()
> 2. Moved `wce`/`d_sense` assignment below the page validity checks
> 3. Added/Removed empty lines where appropriate
>
> Signed-off-by: Tom Yan <tom.ty89@gmail.com>
Perhaps Tejun is OK with that, but if you ask me doing 1 task per patch is
a better practice.
[...]
MBR, Sergei
[toc] | [next] | [standalone]
| From | Tom Yan <tom.ty89@gmail.com> |
|---|---|
| Date | 2016-07-21 21:00 +0200 |
| Message-ID | <rXrmq-2WQ-17@gated-at.bofh.it> |
| In reply to | #1448062 |
This patch should cause no behavioral change. Even the (removal of) the redundant bit mask should be a nop. So it seems like a bit of an overkill to split them. On 22 July 2016 at 02:45, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > On 07/21/2016 09:41 PM, tom.ty89@gmail.com wrote: > >> From: Tom Yan <tom.ty89@gmail.com> >> >> 1. Removed a repeated bit masking in ata_mselect_control() >> 2. Moved `wce`/`d_sense` assignment below the page validity checks >> 3. Added/Removed empty lines where appropriate >> >> Signed-off-by: Tom Yan <tom.ty89@gmail.com> > > > Perhaps Tejun is OK with that, but if you ask me doing 1 task per patch > is a better practice. > > [...] > > MBR, Sergei >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web