Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1448062
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*() |
| Date | 2016-07-21 20:50 +0200 |
| Message-ID | <rXrcJ-2T6-1@gated-at.bofh.it> (permalink) |
| References | <rXrcJ-2T6-3@gated-at.bofh.it> |
| Organization | Cogent Embedded |
Hello.
On 07/21/2016 09:41 PM, tom.ty89@gmail.com wrote:
> From: Tom Yan <tom.ty89@gmail.com>
>
> 1. Removed a repeated bit masking in ata_mselect_control()
> 2. Moved `wce`/`d_sense` assignment below the page validity checks
> 3. Added/Removed empty lines where appropriate
>
> Signed-off-by: Tom Yan <tom.ty89@gmail.com>
Perhaps Tejun is OK with that, but if you ask me doing 1 task per patch is
a better practice.
[...]
MBR, Sergei
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-07-21 20:50 +0200 Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*() Tom Yan <tom.ty89@gmail.com> - 2016-07-21 21:00 +0200
csiph-web