Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1447512 > unrolled thread
| Started by | Bandan Das <bsd@redhat.com> |
|---|---|
| First post | 2016-07-21 00:30 +0200 |
| Last post | 2016-07-21 21:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/4] mmu: don't pass *kvm to spte_write_protect Bandan Das <bsd@redhat.com> - 2016-07-21 00:30 +0200
Re: [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect Paolo Bonzini <pbonzini@redhat.com> - 2016-07-21 11:20 +0200
Re: [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect Bandan Das <bsd@redhat.com> - 2016-07-21 21:30 +0200
| From | Bandan Das <bsd@redhat.com> |
|---|---|
| Date | 2016-07-21 00:30 +0200 |
| Subject | [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect |
| Message-ID | <rX8a6-7mz-11@gated-at.bofh.it> |
That parameter isn't used in the function,
it's probably a historical artifact.
Signed-off-by: Bandan Das <bsd@redhat.com>
---
arch/x86/kvm/mmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index def97b3..aaecd10 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -1204,7 +1204,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep)
*
* Return true if tlb need be flushed.
*/
-static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool pt_protect)
+static bool spte_write_protect(u64 *sptep, bool pt_protect)
{
u64 spte = *sptep;
@@ -1230,7 +1230,7 @@ static bool __rmap_write_protect(struct kvm *kvm,
bool flush = false;
for_each_rmap_spte(rmap_head, &iter, sptep)
- flush |= spte_write_protect(kvm, sptep, pt_protect);
+ flush |= spte_write_protect(sptep, pt_protect);
return flush;
}
--
2.5.5
[toc] | [next] | [standalone]
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Date | 2016-07-21 11:20 +0200 |
| Message-ID | <rXij8-5uu-21@gated-at.bofh.it> |
| In reply to | #1447512 |
On 21/07/2016 00:25, Bandan Das wrote:
> That parameter isn't used in the function,
> it's probably a historical artifact.
Same for spte_clear_dirty and spte_set_dirty, please.
Paolo
> Signed-off-by: Bandan Das <bsd@redhat.com>
> ---
> arch/x86/kvm/mmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index def97b3..aaecd10 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -1204,7 +1204,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep)
> *
> * Return true if tlb need be flushed.
> */
> -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool pt_protect)
> +static bool spte_write_protect(u64 *sptep, bool pt_protect)
> {
> u64 spte = *sptep;
>
> @@ -1230,7 +1230,7 @@ static bool __rmap_write_protect(struct kvm *kvm,
> bool flush = false;
>
> for_each_rmap_spte(rmap_head, &iter, sptep)
> - flush |= spte_write_protect(kvm, sptep, pt_protect);
> + flush |= spte_write_protect(sptep, pt_protect);
>
> return flush;
> }
>
[toc] | [prev] | [next] | [standalone]
| From | Bandan Das <bsd@redhat.com> |
|---|---|
| Date | 2016-07-21 21:30 +0200 |
| Message-ID | <rXrPr-3ny-3@gated-at.bofh.it> |
| In reply to | #1447730 |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 21/07/2016 00:25, Bandan Das wrote:
>> That parameter isn't used in the function,
>> it's probably a historical artifact.
>
> Same for spte_clear_dirty and spte_set_dirty, please.
Sure! I will fix this in a follow-up.
Bandan
> Paolo
>
>> Signed-off-by: Bandan Das <bsd@redhat.com>
>> ---
>> arch/x86/kvm/mmu.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
>> index def97b3..aaecd10 100644
>> --- a/arch/x86/kvm/mmu.c
>> +++ b/arch/x86/kvm/mmu.c
>> @@ -1204,7 +1204,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep)
>> *
>> * Return true if tlb need be flushed.
>> */
>> -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool pt_protect)
>> +static bool spte_write_protect(u64 *sptep, bool pt_protect)
>> {
>> u64 spte = *sptep;
>>
>> @@ -1230,7 +1230,7 @@ static bool __rmap_write_protect(struct kvm *kvm,
>> bool flush = false;
>>
>> for_each_rmap_spte(rmap_head, &iter, sptep)
>> - flush |= spte_write_protect(kvm, sptep, pt_protect);
>> + flush |= spte_write_protect(sptep, pt_protect);
>>
>> return flush;
>> }
>>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web