Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1447730
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect |
| Date | 2016-07-21 11:20 +0200 |
| Message-ID | <rXij8-5uu-21@gated-at.bofh.it> (permalink) |
| References | <rX8a6-7mz-9@gated-at.bofh.it> <rX8a6-7mz-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 21/07/2016 00:25, Bandan Das wrote:
> That parameter isn't used in the function,
> it's probably a historical artifact.
Same for spte_clear_dirty and spte_set_dirty, please.
Paolo
> Signed-off-by: Bandan Das <bsd@redhat.com>
> ---
> arch/x86/kvm/mmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index def97b3..aaecd10 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -1204,7 +1204,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep)
> *
> * Return true if tlb need be flushed.
> */
> -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool pt_protect)
> +static bool spte_write_protect(u64 *sptep, bool pt_protect)
> {
> u64 spte = *sptep;
>
> @@ -1230,7 +1230,7 @@ static bool __rmap_write_protect(struct kvm *kvm,
> bool flush = false;
>
> for_each_rmap_spte(rmap_head, &iter, sptep)
> - flush |= spte_write_protect(kvm, sptep, pt_protect);
> + flush |= spte_write_protect(sptep, pt_protect);
>
> return flush;
> }
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/4] mmu: don't pass *kvm to spte_write_protect Bandan Das <bsd@redhat.com> - 2016-07-21 00:30 +0200
Re: [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect Paolo Bonzini <pbonzini@redhat.com> - 2016-07-21 11:20 +0200
Re: [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect Bandan Das <bsd@redhat.com> - 2016-07-21 21:30 +0200
csiph-web