Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447845 > unrolled thread

[PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    [PATCH 10/18] ARM: mvebu: a39x: enable watchdog for all Armada-39x SoCs Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    [PATCH 11/18] ARM: mvebu: a39x: add missing nodes describing GPIO's Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
      Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC  family Rob Herring <robh@kernel.org> - 2016-07-22 00:20 +0200
        Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-22 11:20 +0200
          Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family Rob Herring <robh@kernel.org> - 2016-07-25 15:50 +0200
            Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC  family Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-07-25 16:00 +0200
              Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family Rob Herring <robh@kernel.org> - 2016-07-25 17:20 +0200
                Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC  family Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-07-25 20:30 +0200
    [PATCH 06/18] ARM: mvebu: a390: add missing compatibility string and add missing bracket Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    [PATCH 08/18] ARM: mvebu: a39x: Enable PMU, CA9 MPcore SoC Controller and Coherency fabric Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    [PATCH 09/18] ARM: mvebu: a39x: enable the thermal sensor in Armada-39x SoCs Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    [PATCH 16/18] ARM: mvebu: a398-db: enable supported usb interfaces Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    [PATCH 13/18] ARM: mvebu: a39x: enable rtc for all Armada-39x SoCs Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    Re: [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7  defconfig improvements Andrew Lunn <andrew@lunn.ch> - 2016-07-21 15:50 +0200
      Re: [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-22 10:00 +0200

#1447845 — [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements

First 3 patches enables some commonly used features in mvebu_v7_defconfig.

Patches 4 and 5 updates armada-385-db-ap.dts. Then patch 6 is currently a fix
for broken Armada 390 dtsi.

Patches 7 to 13 updates the armada-39x.dtsi about features which all can be
supported with existing drivers.

Patch 14 introduces armada-395.dtsi which describes Armada 395 SoC family and
patch 15 updates armada-398.dtsi. Next patch updates Armada 398 DB dts about
supported usb interfaces and finally last 2 patches introduces description for 2
board: Armada 390 DB and Armada 395 GP.

Grzegorz Jaszczyk (18):
  ARM: mvebu: enable MTD command line partition table in
    mvebu_v7_defconfig
  ARM: mvebu: enable UBI and UBIFS in mvebu_v7_defconfig
  ARM: mvebu: enable E1000E in mvebu_v7_defconfig
  ARM: mvebu: a385-db-ap: enable USB (orion-ehci) port
  ARM: mvebu: a385-db-ap: add default partition description for NAND
  ARM: mvebu: a390: add missing compatibility string and add missing
    bracket
  ARM: mvebu: a39x: update the SDHCI node on Armada 39x
  ARM: mvebu: a39x: enable PMU, CA9 MPcore SoC Controller and Coherency
    fabric
  ARM: mvebu: a39x: enable the thermal sensor in Armada-39x SoCs
  ARM: mvebu: a39x: enable watchdog for all Armada-39x SoCs
  ARM: mvebu: a39x: add missing nodes describing GPIO's
  ARM: mvebu: a39x: add missing nodes describing USB2.0 and USB3.0
  ARM: mvebu: a39x: enable rtc for all Armada-39x SoCs
  ARM: mvebu: add support for the Armada 395 SoC family
  ARM: mvebu: a398: update the dtsi about missing interfaces
  ARM: mvebu: a398-db: enable supported usb interfaces
  ARM: mvebu: a390-db: add support for the Armada 390 DB board
  ARM: mvebu: a395-gp: add support for the Armada 395 GP Board

 .../devicetree/bindings/arm/marvell/armada-39x.txt |   2 +-
 arch/arm/boot/dts/armada-385-db-ap.dts             |  30 +++-
 arch/arm/boot/dts/armada-390-db.dts                | 164 +++++++++++++++++++++
 arch/arm/boot/dts/armada-390.dtsi                  |   3 +
 arch/arm/boot/dts/armada-395-gp.dts                | 147 ++++++++++++++++++
 arch/arm/boot/dts/armada-395.dtsi                  |  76 ++++++++++
 arch/arm/boot/dts/armada-398-db.dts                |   8 +
 arch/arm/boot/dts/armada-398.dtsi                  |  10 +-
 arch/arm/boot/dts/armada-39x.dtsi                  |  94 +++++++++++-
 arch/arm/configs/mvebu_v7_defconfig                |   4 +
 10 files changed, 532 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm/boot/dts/armada-390-db.dts
 create mode 100644 arch/arm/boot/dts/armada-395-gp.dts
 create mode 100644 arch/arm/boot/dts/armada-395.dtsi

-- 
1.8.3.1

[toc] | [next] | [standalone]

#1447846 — [PATCH 10/18] ARM: mvebu: a39x: enable watchdog for all Armada-39x SoCs

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Reviewed-by: Lior Amsalem <alior@marvell.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index 03dc0ec..5e01438 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -322,6 +322,14 @@
 				clock-names = "nbclk", "fixed";
 			};
 
+			watchdog@20300 {
+				compatible = "marvell,armada-380-wdt";
+				reg = <0x20300 0x34>, <0x20704 0x4>,
+				      <0x18260 0x4>;
+				clocks = <&coreclk 2>, <&refclk>;
+				clock-names = "nbclk", "fixed";
+			};
+
 			cpurst@20800 {
 				compatible = "marvell,armada-370-cpu-reset";
 				reg = <0x20800 0x10>;
@@ -534,5 +542,12 @@
 			#clock-cells = <0>;
 			clock-frequency = <1000000000>;
 		};
+
+		/* 25 MHz reference crystal */
+		refclk: oscillator {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <25000000>;
+		};
 	};
 };
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1447848 — [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/configs/mvebu_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
index f1a0e25..000a866 100644
--- a/arch/arm/configs/mvebu_v7_defconfig
+++ b/arch/arm/configs/mvebu_v7_defconfig
@@ -69,6 +69,7 @@ CONFIG_AHCI_MVEBU=y
 CONFIG_SATA_MV=y
 CONFIG_NETDEVICES=y
 CONFIG_NET_DSA_MV88E6XXX=y
+CONFIG_E1000E=y
 CONFIG_MV643XX_ETH=y
 CONFIG_MVNETA=y
 CONFIG_MVPP2=y
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1447849 — [PATCH 11/18] ARM: mvebu: a39x: add missing nodes describing GPIO's

The whole Armada 39x SoC family of processors has GPIO's which all can be
supported with existing driver.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index 5e01438..0749878 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -55,6 +55,8 @@
 	compatible = "marvell,armada390";
 
 	aliases {
+		gpio0 = &gpio0;
+		gpio1 = &gpio1;
 		serial0 = &uart0;
 		serial1 = &uart1;
 		serial2 = &uart2;
@@ -274,6 +276,34 @@
 				};
 			};
 
+			gpio0: gpio@18100 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18100 0x40>;
+				ngpios = <32>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
+			gpio1: gpio@18140 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18140 0x40>;
+				ngpios = <28>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
 			system-controller@18200 {
 				compatible = "marvell,armada-390-system-controller",
 					     "marvell,armada-370-xp-system-controller";
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1447850 — [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

Beside interfaces described in the armada-39x.dtsi, the Armada 395 SoC
family supports: 2 x SATA3 (2 ports in one unit) and the USB3.0

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 .../devicetree/bindings/arm/marvell/armada-39x.txt |  2 +-
 arch/arm/boot/dts/armada-395.dtsi                  | 76 ++++++++++++++++++++++
 2 files changed, 77 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/armada-395.dtsi

diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
index 53d4ff9..f066801 100644
--- a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
+++ b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
@@ -17,4 +17,4 @@ compatible: must contain "marvell,armada398"
 
 Example:
 
-compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
+compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";
diff --git a/arch/arm/boot/dts/armada-395.dtsi b/arch/arm/boot/dts/armada-395.dtsi
new file mode 100644
index 0000000..ab5dc49
--- /dev/null
+++ b/arch/arm/boot/dts/armada-395.dtsi
@@ -0,0 +1,76 @@
+/*
+ * Device Tree Include file for Marvell Armada 395 SoC.
+ *
+ * Copyright (C) 2016 Marvell
+ *
+ * Grzegorz Jaszczyk <jaz@semihalf.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "armada-39x.dtsi"
+
+/ {
+	compatible = "marvell,armada395", "marvell,armada390";
+
+	soc {
+		internal-regs {
+			pinctrl@18000 {
+				compatible = "marvell,mv88f6925-pinctrl";
+				reg = <0x18000 0x20>;
+			};
+
+			sata@a8000 {
+				compatible = "marvell,armada-380-ahci";
+				reg = <0xa8000 0x2000>;
+				interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 15>;
+				status = "disabled";
+			};
+
+			usb3@f0000 {
+				compatible = "marvell,armada-380-xhci";
+				reg = <0xf0000 0x4000>,<0xf4000 0x4000>;
+				interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 9>;
+				status = "disabled";
+			};
+		};
+	};
+};
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1448225 — Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

On Thu, Jul 21, 2016 at 02:44:11PM +0200, Grzegorz Jaszczyk wrote:
> Beside interfaces described in the armada-39x.dtsi, the Armada 395 SoC
> family supports: 2 x SATA3 (2 ports in one unit) and the USB3.0
> 
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> ---
>  .../devicetree/bindings/arm/marvell/armada-39x.txt |  2 +-
>  arch/arm/boot/dts/armada-395.dtsi                  | 76 ++++++++++++++++++++++
>  2 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/armada-395.dtsi
> 
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
> index 53d4ff9..f066801 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
> @@ -17,4 +17,4 @@ compatible: must contain "marvell,armada398"
>  
>  Example:
>  
> -compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
> +compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";

If 395 came after 398, then it should come first in the order. This 
implies that marvell,armada398 is a better match than marvell,armada395. 
Or perhaps you shouldn't have both?

Rob

[toc] | [prev] | [next] | [standalone]

#1448491 — Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

Hi Rob,

2016-07-22 0:16 GMT+02:00 Rob Herring <robh@kernel.org>:
> On Thu, Jul 21, 2016 at 02:44:11PM +0200, Grzegorz Jaszczyk wrote:
>> -compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
>> +compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";
>
> If 395 came after 398, then it should come first in the order. This
> implies that marvell,armada398 is a better match than marvell,armada395.
> Or perhaps you shouldn't have both?
>
> Rob

I am not sure if I get your point. The Armada-398 extends the
Armada-395 about 2 additional SATA ports (as you can see in commit
"[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
interfaces"). In this example the a398-db board contains the Armada398
SoC, so it is a better match and goes first.

Quite the same is for existing armada-388-db.dts, in which compatible
looks like this:
compatible = "marvell,a385-db", "marvell,armada388",
"marvell,armada385", "marvell,armada380";

In above, Armada-388 also extends the Armada-385 and the order of the
compatible is similar to one from my example.

Thank you,
Grzegorz

[toc] | [prev] | [next] | [standalone]

#1449500 — Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

On Fri, Jul 22, 2016 at 4:10 AM, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:
> Hi Rob,
>
> 2016-07-22 0:16 GMT+02:00 Rob Herring <robh@kernel.org>:
>> On Thu, Jul 21, 2016 at 02:44:11PM +0200, Grzegorz Jaszczyk wrote:
>>> -compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
>>> +compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";
>>
>> If 395 came after 398, then it should come first in the order. This
>> implies that marvell,armada398 is a better match than marvell,armada395.
>> Or perhaps you shouldn't have both?
>>
>> Rob
>
> I am not sure if I get your point. The Armada-398 extends the
> Armada-395 about 2 additional SATA ports (as you can see in commit
> "[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
> interfaces"). In this example the a398-db board contains the Armada398
> SoC, so it is a better match and goes first.

But your patch title is adding 395 support, but you are adding the
string to a 398 based board. It would make sense to have 395 here if
the OS already had support for 395 and you want to support the 398
without updating the OS. That doesn't seem to apply here.

> Quite the same is for existing armada-388-db.dts, in which compatible
> looks like this:
> compatible = "marvell,a385-db", "marvell,armada388",
> "marvell,armada385", "marvell,armada380";

Maybe so, but IMO this looks a bit excessive.

The problem is what if you need to apply a fix for only 395 (or 385),
but not 398? If you put both strings in, you can't distinguish you are
running on a 395 or 398 SoC. You would have to check for !398 and any
other SoCs you've claimed are 395 compatible. Maybe you have ID
registers you can read to distinguish SoCs, but then you don't need
the strings in that case either. The flip side is if you need a fix
for both, then the OS can easily check for either string.

Rob

[toc] | [prev] | [next] | [standalone]

#1449502 — Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

Hello,

On Mon, 25 Jul 2016 08:47:23 -0500, Rob Herring wrote:

> > I am not sure if I get your point. The Armada-398 extends the
> > Armada-395 about 2 additional SATA ports (as you can see in commit
> > "[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
> > interfaces"). In this example the a398-db board contains the Armada398
> > SoC, so it is a better match and goes first.  
> 
> But your patch title is adding 395 support, but you are adding the
> string to a 398 based board. It would make sense to have 395 here if
> the OS already had support for 395 and you want to support the 398
> without updating the OS. That doesn't seem to apply here.

I think the argument of Grzegorz is that the 398 is functionally a
strict superset of the 395, so that anything that applies to the 395
will also apply to 398.

Now, whether it is a good idea to consider them "compatible" in the DT
sense, I'm not sure.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1449568 — Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

On Mon, Jul 25, 2016 at 8:50 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 25 Jul 2016 08:47:23 -0500, Rob Herring wrote:
>
>> > I am not sure if I get your point. The Armada-398 extends the
>> > Armada-395 about 2 additional SATA ports (as you can see in commit
>> > "[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
>> > interfaces"). In this example the a398-db board contains the Armada398
>> > SoC, so it is a better match and goes first.
>>
>> But your patch title is adding 395 support, but you are adding the
>> string to a 398 based board. It would make sense to have 395 here if
>> the OS already had support for 395 and you want to support the 398
>> without updating the OS. That doesn't seem to apply here.
>
> I think the argument of Grzegorz is that the 398 is functionally a
> strict superset of the 395, so that anything that applies to the 395
> will also apply to 398.

Yes, I get that, but that is only meaningful if you want to run an OS
that is only aware of 395 on a 398 SoC/board (though I'd guess the 390
compat is enough for that). Otherwise, that property is not really
meaningful as the additional nodes are enough to handle what is the
superset.

I would agree both are fine if both chips are in fact the same die,
just fused or packaged differently. I've seen a lot of chips that are
supposed to be sub/supersets of each other, but have different errata
lists because they are different die.

Rob

[toc] | [prev] | [next] | [standalone]

#1449728 — Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

Hello,

On Mon, 25 Jul 2016 10:12:43 -0500, Rob Herring wrote:

> Yes, I get that, but that is only meaningful if you want to run an OS
> that is only aware of 395 on a 398 SoC/board (though I'd guess the 390
> compat is enough for that). Otherwise, that property is not really
> meaningful as the additional nodes are enough to handle what is the
> superset.
> 
> I would agree both are fine if both chips are in fact the same die,
> just fused or packaged differently. I've seen a lot of chips that are
> supposed to be sub/supersets of each other, but have different errata
> lists because they are different die.

Unfortunately HW vendors are rarely willing to publicly indicate whether
the different chips in their families are actually the same die fused
differently, or really different dies.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1447854 — [PATCH 06/18] ARM: mvebu: a390: add missing compatibility string and add missing bracket

The armada-390.dtsi was broken since the first patch which adds Device Tree
files for Armada 39x SoC was introduced.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Cc: <stable@vger.kernel.org> # 4.0+
Fixes 538da83 ("ARM: mvebu: add Device Tree files for Armada 39x SoC and board")
---
 arch/arm/boot/dts/armada-390.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/armada-390.dtsi b/arch/arm/boot/dts/armada-390.dtsi
index 094e39c..6cd18d8 100644
--- a/arch/arm/boot/dts/armada-390.dtsi
+++ b/arch/arm/boot/dts/armada-390.dtsi
@@ -47,6 +47,8 @@
 #include "armada-39x.dtsi"
 
 / {
+	compatible = "marvell,armada390";
+
 	soc {
 		internal-regs {
 			pinctrl@18000 {
@@ -54,4 +56,5 @@
 				reg = <0x18000 0x20>;
 			};
 		};
+	};
 };
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1447856 — [PATCH 08/18] ARM: mvebu: a39x: Enable PMU, CA9 MPcore SoC Controller and Coherency fabric

This commit enables:
- CA9's Performance Monitor Unit
- CA9 MPcore SoC Controller
- Coherency fabric
on Armada 39x, basing on the Armada 38x (which has the same CA9 CPU).

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Reviewed-by: Lior Amsalem <alior@marvell.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index cb66f20..8a22c02 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -78,6 +78,11 @@
 		};
 	};
 
+	pmu {
+		compatible = "arm,cortex-a9-pmu";
+		interrupts-extended = <&mpic 3>;
+	};
+
 	soc {
 		compatible = "marvell,armada390-mbus", "marvell,armadaxp-mbus",
 			     "simple-bus";
@@ -322,6 +327,16 @@
 				reg = <0x20800 0x10>;
 			};
 
+			mpcore-soc-ctrl@20d20 {
+				compatible = "marvell,armada-380-mpcore-soc-ctrl";
+				reg = <0x20d20 0x6c>;
+			};
+
+			coherency-fabric@21010 {
+				compatible = "marvell,armada-380-coherency-fabric";
+				reg = <0x21010 0x1c>;
+			};
+
 			pmsu@22000 {
 				compatible = "marvell,armada-390-pmsu",
 					     "marvell,armada-380-pmsu";
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1447857 — [PATCH 09/18] ARM: mvebu: a39x: enable the thermal sensor in Armada-39x SoCs

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index 8a22c02..03dc0ec 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -413,6 +413,12 @@
 				clocks = <&mainpll>;
 				clock-output-names = "nand";
 			};
+
+			thermal@e8078 {
+				compatible = "marvell,armada380-thermal";
+				reg = <0xe4078 0x4>, <0xe4074 0x4>;
+				status = "okay";
+			};
 		};
 
 		pcie-controller {
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1447858 — [PATCH 16/18] ARM: mvebu: a398-db: enable supported usb interfaces

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-398-db.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/armada-398-db.dts b/arch/arm/boot/dts/armada-398-db.dts
index 788c3ba..969b49f 100644
--- a/arch/arm/boot/dts/armada-398-db.dts
+++ b/arch/arm/boot/dts/armada-398-db.dts
@@ -108,6 +108,10 @@
 				status = "okay";
 			};
 
+			usb@58000 {
+				status = "okay";
+			};
+
 			flash@d0000 {
 				status = "okay";
 				pinctrl-0 = <&nand_pins>;
@@ -132,6 +136,10 @@
 					reg = <0x1000000 0x3f000000>;
 				};
 			};
+
+			usb3@f8000 {
+				status = "okay";
+			};
 		};
 
 		pcie-controller {
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1447859 — [PATCH 13/18] ARM: mvebu: a39x: enable rtc for all Armada-39x SoCs

Despite that FS states that rtc is present only in A395 and A398 and not in
A390, the rtc is working with A390.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index 1225cd8..5bed8b9 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -429,6 +429,13 @@
 				};
 			};
 
+			rtc@a3800 {
+				compatible = "marvell,armada-380-rtc";
+				reg = <0xa3800 0x20>, <0x184a0 0x0c>;
+				reg-names = "rtc", "rtc-soc";
+				interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
 			flash@d0000 {
 				compatible = "marvell,armada370-nand";
 				reg = <0xd0000 0x54>;
-- 
1.8.3.1

[toc] | [prev] | [next] | [standalone]

#1447894 — Re: [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements

On Thu, Jul 21, 2016 at 02:43:56PM +0200, Grzegorz Jaszczyk wrote:

Hi Grzegorz

Some of these patches are missing a commit log entry. Please add at
least one line.

      Andrew

[toc] | [prev] | [next] | [standalone]

#1448450

Hi Andrew,

2016-07-21 15:43 GMT+02:00 Andrew Lunn <andrew@lunn.ch>:
> On Thu, Jul 21, 2016 at 02:43:56PM +0200, Grzegorz Jaszczyk wrote:
>
> Hi Grzegorz
>
> Some of these patches are missing a commit log entry. Please add at
> least one line.
>

Ok, I will add it in next version of this patch-set, which I am
planning to resubmit next week. Maybe I will get more feedback till
then.

Thank you,
Grzegorz

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web