Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1448491

Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

Show all headers | View raw

Hi Rob,

2016-07-22 0:16 GMT+02:00 Rob Herring <robh@kernel.org>:
> On Thu, Jul 21, 2016 at 02:44:11PM +0200, Grzegorz Jaszczyk wrote:
>> -compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
>> +compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";
>
> If 395 came after 398, then it should come first in the order. This
> implies that marvell,armada398 is a better match than marvell,armada395.
> Or perhaps you shouldn't have both?
>
> Rob

I am not sure if I get your point. The Armada-398 extends the
Armada-395 about 2 additional SATA ports (as you can see in commit
"[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
interfaces"). In this example the a398-db board contains the Armada398
SoC, so it is a better match and goes first.

Quite the same is for existing armada-388-db.dts, in which compatible
looks like this:
compatible = "marvell,a385-db", "marvell,armada388",
"marvell,armada385", "marvell,armada380";

In above, Armada-388 also extends the Armada-385 and the order of the
compatible is similar to one from my example.

Thank you,
Grzegorz

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
  [PATCH 10/18] ARM: mvebu: a39x: enable watchdog for all Armada-39x SoCs Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
  [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
  [PATCH 11/18] ARM: mvebu: a39x: add missing nodes describing GPIO's Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
  [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
    Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC  family Rob Herring <robh@kernel.org> - 2016-07-22 00:20 +0200
      Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-22 11:20 +0200
        Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family Rob Herring <robh@kernel.org> - 2016-07-25 15:50 +0200
          Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC  family Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-07-25 16:00 +0200
            Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family Rob Herring <robh@kernel.org> - 2016-07-25 17:20 +0200
              Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC  family Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-07-25 20:30 +0200
  [PATCH 06/18] ARM: mvebu: a390: add missing compatibility string and add missing bracket Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
  [PATCH 08/18] ARM: mvebu: a39x: Enable PMU, CA9 MPcore SoC Controller and Coherency fabric Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
  [PATCH 09/18] ARM: mvebu: a39x: enable the thermal sensor in Armada-39x SoCs Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
  [PATCH 16/18] ARM: mvebu: a398-db: enable supported usb interfaces Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
  [PATCH 13/18] ARM: mvebu: a39x: enable rtc for all Armada-39x SoCs Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 14:50 +0200
  Re: [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7  defconfig improvements Andrew Lunn <andrew@lunn.ch> - 2016-07-21 15:50 +0200
    Re: [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-22 10:00 +0200

csiph-web