Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1446369 > unrolled thread
| Started by | Wei Yongjun <weiyj_lk@163.com> |
|---|---|
| First post | 2016-07-19 14:10 +0200 |
| Last post | 2016-07-19 21:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() Wei Yongjun <weiyj_lk@163.com> - 2016-07-19 14:10 +0200
Re: [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-07-19 20:10 +0200
Re: [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() Sean Paul <seanpaul@google.com> - 2016-07-19 21:50 +0200
| From | Wei Yongjun <weiyj_lk@163.com> |
|---|---|
| Date | 2016-07-19 14:10 +0200 |
| Subject | [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() |
| Message-ID | <rWC0x-3PW-5@gated-at.bofh.it> |
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/gpu/drm/arc/arcpgu_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
index 0226ec0..ef1d702 100644
--- a/drivers/gpu/drm/arc/arcpgu_drv.c
+++ b/drivers/gpu/drm/arc/arcpgu_drv.c
@@ -104,10 +104,8 @@ static int arcpgu_load(struct drm_device *drm)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
arcpgu->regs = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(arcpgu->regs)) {
- dev_err(drm->dev, "Could not remap IO mem\n");
+ if (IS_ERR(arcpgu->regs))
return PTR_ERR(arcpgu->regs);
- }
dev_info(drm->dev, "arc_pgu ID: 0x%x\n",
arc_pgu_read(arcpgu, ARCPGU_REG_ID));
[toc] | [next] | [standalone]
| From | Alexey Brodkin <Alexey.Brodkin@synopsys.com> |
|---|---|
| Date | 2016-07-19 20:10 +0200 |
| Subject | Re: [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() |
| Message-ID | <rWHCW-7l9-19@gated-at.bofh.it> |
| In reply to | #1446369 |
Hi+AKA-Wei Yongjun, On Tue, 2016-07-19 at 12:01 +-0000, Wei Yongjun wrote: +AD4- From: Wei Yongjun +ADw-yongjun+AF8-wei+AEA-trendmicro.com.cn+AD4- +AD4- +AD4- There is a error message within devm+AF8-ioremap+AF8-resource +AD4- already, so remove the dev+AF8-err call to avoid redundant +AD4- error message. +AD4- +AD4- Signed-off-by: Wei Yongjun +ADw-yongjun+AF8-wei+AEA-trendmicro.com.cn+AD4- Acked-by: Alexey Brodkin +ADw-abrodkin+AEA-synopsys.com+AD4-
[toc] | [prev] | [next] | [standalone]
| From | Sean Paul <seanpaul@google.com> |
|---|---|
| Date | 2016-07-19 21:50 +0200 |
| Message-ID | <rWJbH-8bB-15@gated-at.bofh.it> |
| In reply to | #1446626 |
On Tue, Jul 19, 2016 at 2:02 PM, Alexey Brodkin <Alexey.Brodkin@synopsys.com> wrote: > Hi Wei Yongjun, > > On Tue, 2016-07-19 at 12:01 +0000, Wei Yongjun wrote: >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> >> >> There is a error message within devm_ioremap_resource >> already, so remove the dev_err call to avoid redundant >> error message. >> >> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Acked-by: Alexey Brodkin <abrodkin@synopsys.com> Merged to drm-misc
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web