Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446369

[PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load()

Show all headers | View raw

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/gpu/drm/arc/arcpgu_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
index 0226ec0..ef1d702 100644
--- a/drivers/gpu/drm/arc/arcpgu_drv.c
+++ b/drivers/gpu/drm/arc/arcpgu_drv.c
@@ -104,10 +104,8 @@ static int arcpgu_load(struct drm_device *drm)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	arcpgu->regs = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(arcpgu->regs)) {
-		dev_err(drm->dev, "Could not remap IO mem\n");
+	if (IS_ERR(arcpgu->regs))
 		return PTR_ERR(arcpgu->regs);
-	}
 
 	dev_info(drm->dev, "arc_pgu ID: 0x%x\n",
 		 arc_pgu_read(arcpgu, ARCPGU_REG_ID));

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() Wei Yongjun <weiyj_lk@163.com> - 2016-07-19 14:10 +0200
  Re: [PATCH -next] drm/arc: Remove redundant dev_err call in  arcpgu_load() Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-07-19 20:10 +0200
    Re: [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() Sean Paul <seanpaul@google.com> - 2016-07-19 21:50 +0200

csiph-web