Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1446554 > unrolled thread

Re: [PATCH] rtc: abx80x: use devm_add_action_or_reset()

Started byAlexandre Belloni <alexandre.belloni@free-electrons.com>
First post2016-07-19 17:40 +0200
Last post2016-07-19 17:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] rtc: abx80x: use devm_add_action_or_reset() Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-19 17:40 +0200

#1446554 — Re: [PATCH] rtc: abx80x: use devm_add_action_or_reset()

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2016-07-19 17:40 +0200
SubjectRe: [PATCH] rtc: abx80x: use devm_add_action_or_reset()
Message-ID<rWFhM-5LH-29@gated-at.bofh.it>
On 03/07/2016 at 21:32:22 +0100, Sudip Mukherjee wrote :
> If devm_add_action() fails we are explicitly calling the cleanup to free
> the resources allocated.  Lets use the helper devm_add_action_or_reset()
> and return directly in case of error, as we know that the cleanup function
> has been already called by the helper if there was any error.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>  drivers/rtc/rtc-abx80x.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web