Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1446554

Re: [PATCH] rtc: abx80x: use devm_add_action_or_reset()

From Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH] rtc: abx80x: use devm_add_action_or_reset()
Date 2016-07-19 17:40 +0200
Message-ID <rWFhM-5LH-29@gated-at.bofh.it> (permalink)
References <rQWlk-4MM-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 03/07/2016 at 21:32:22 +0100, Sudip Mukherjee wrote :
> If devm_add_action() fails we are explicitly calling the cleanup to free
> the resources allocated.  Lets use the helper devm_add_action_or_reset()
> and return directly in case of error, as we know that the cleanup function
> has been already called by the helper if there was any error.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>  drivers/rtc/rtc-abx80x.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] rtc: abx80x: use devm_add_action_or_reset() Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-19 17:40 +0200

csiph-web