Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1443827 > unrolled thread

[PATCH] tpm_tis_core: convert max timeouts from msec to jiffies

Started byAndrey Pronin <apronin@chromium.org>
First post2016-07-15 02:30 +0200
Last post2016-07-18 20:50 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Andrey Pronin <apronin@chromium.org> - 2016-07-15 02:30 +0200
    Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-07-15 05:10 +0200
    Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-07-18 20:50 +0200
      Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-07-19 15:00 +0200
    Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-07-18 20:50 +0200
    Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-07-18 20:50 +0200

#1443827 — [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies

FromAndrey Pronin <apronin@chromium.org>
Date2016-07-15 02:30 +0200
Subject[PATCH] tpm_tis_core: convert max timeouts from msec to jiffies
Message-ID<rUZaV-8gA-1@gated-at.bofh.it>
tpm_tis_core was missing conversion from msec when assigning
max timeouts from constants.

Signed-off-by: Andrey Pronin <apronin@chromium.org>
---
 drivers/char/tpm/tpm_tis_core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 8110b52..fb8c3de 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -666,10 +666,10 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
 #endif
 
 	/* Maximum timeouts */
-	chip->timeout_a = TIS_TIMEOUT_A_MAX;
-	chip->timeout_b = TIS_TIMEOUT_B_MAX;
-	chip->timeout_c = TIS_TIMEOUT_C_MAX;
-	chip->timeout_d = TIS_TIMEOUT_D_MAX;
+	chip->timeout_a = msecs_to_jiffies(TIS_TIMEOUT_A_MAX);
+	chip->timeout_b = msecs_to_jiffies(TIS_TIMEOUT_B_MAX);
+	chip->timeout_c = msecs_to_jiffies(TIS_TIMEOUT_C_MAX);
+	chip->timeout_d = msecs_to_jiffies(TIS_TIMEOUT_D_MAX);
 	priv->phy_ops = phy_ops;
 	dev_set_drvdata(&chip->dev, priv);
 
-- 
2.6.6

[toc] | [next] | [standalone]

#1443906

FromJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Date2016-07-15 05:10 +0200
Message-ID<rV1FL-1xr-5@gated-at.bofh.it>
In reply to#1443827
On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote:
> tpm_tis_core was missing conversion from msec when assigning
> max timeouts from constants.

Yep.

Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Jason

[toc] | [prev] | [next] | [standalone]

#1445706

FromJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Date2016-07-18 20:50 +0200
Message-ID<rWlM6-1sH-11@gated-at.bofh.it>
In reply to#1443827
On Mon, Jul 18, 2016 at 09:45:32PM +0300, Jarkko Sakkinen wrote:
> On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote:
> > tpm_tis_core was missing conversion from msec when assigning
> > max timeouts from constants.
> > 
> > Signed-off-by: Andrey Pronin <apronin@chromium.org>
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Fixes: 41a5e1cf1fe1

Not sure that fixes isn't right, it looks like it has been broken for
a really long time..

Jason

[toc] | [prev] | [next] | [standalone]

#1446429

FromJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Date2016-07-19 15:00 +0200
Message-ID<rWCN1-47Q-39@gated-at.bofh.it>
In reply to#1445706
On Mon, Jul 18, 2016 at 12:49:29PM -0600, Jason Gunthorpe wrote:
> On Mon, Jul 18, 2016 at 09:45:32PM +0300, Jarkko Sakkinen wrote:
> > On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote:
> > > tpm_tis_core was missing conversion from msec when assigning
> > > max timeouts from constants.
> > > 
> > > Signed-off-by: Andrey Pronin <apronin@chromium.org>
> > 
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Fixes: 41a5e1cf1fe1
> 
> Not sure that fixes isn't right, it looks like it has been broken for
> a really long time..

Thanks, I fixed the commit ID (in my GIT).

> Jason

/Jarkko

[toc] | [prev] | [next] | [standalone]

#1445716

FromJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Date2016-07-18 20:50 +0200
Message-ID<rWlM6-1sH-35@gated-at.bofh.it>
In reply to#1443827
On Mon, Jul 18, 2016 at 09:45:32PM +0300, Jarkko Sakkinen wrote:
> On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote:
> > tpm_tis_core was missing conversion from msec when assigning
> > max timeouts from constants.
> > 
> > Signed-off-by: Andrey Pronin <apronin@chromium.org>
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Fixes: 41a5e1cf1fe1

Applied.

/Jarkko

> /Jarkko
> 
> > ---
> >  drivers/char/tpm/tpm_tis_core.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> > index 8110b52..fb8c3de 100644
> > --- a/drivers/char/tpm/tpm_tis_core.c
> > +++ b/drivers/char/tpm/tpm_tis_core.c
> > @@ -666,10 +666,10 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
> >  #endif
> >  
> >  	/* Maximum timeouts */
> > -	chip->timeout_a = TIS_TIMEOUT_A_MAX;
> > -	chip->timeout_b = TIS_TIMEOUT_B_MAX;
> > -	chip->timeout_c = TIS_TIMEOUT_C_MAX;
> > -	chip->timeout_d = TIS_TIMEOUT_D_MAX;
> > +	chip->timeout_a = msecs_to_jiffies(TIS_TIMEOUT_A_MAX);
> > +	chip->timeout_b = msecs_to_jiffies(TIS_TIMEOUT_B_MAX);
> > +	chip->timeout_c = msecs_to_jiffies(TIS_TIMEOUT_C_MAX);
> > +	chip->timeout_d = msecs_to_jiffies(TIS_TIMEOUT_D_MAX);
> >  	priv->phy_ops = phy_ops;
> >  	dev_set_drvdata(&chip->dev, priv);
> >  
> > -- 
> > 2.6.6
> >

[toc] | [prev] | [next] | [standalone]

#1445717

FromJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Date2016-07-18 20:50 +0200
Message-ID<rWlM6-1sH-13@gated-at.bofh.it>
In reply to#1443827
On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote:
> tpm_tis_core was missing conversion from msec when assigning
> max timeouts from constants.
> 
> Signed-off-by: Andrey Pronin <apronin@chromium.org>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Fixes: 41a5e1cf1fe1

/Jarkko

> ---
>  drivers/char/tpm/tpm_tis_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index 8110b52..fb8c3de 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -666,10 +666,10 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
>  #endif
>  
>  	/* Maximum timeouts */
> -	chip->timeout_a = TIS_TIMEOUT_A_MAX;
> -	chip->timeout_b = TIS_TIMEOUT_B_MAX;
> -	chip->timeout_c = TIS_TIMEOUT_C_MAX;
> -	chip->timeout_d = TIS_TIMEOUT_D_MAX;
> +	chip->timeout_a = msecs_to_jiffies(TIS_TIMEOUT_A_MAX);
> +	chip->timeout_b = msecs_to_jiffies(TIS_TIMEOUT_B_MAX);
> +	chip->timeout_c = msecs_to_jiffies(TIS_TIMEOUT_C_MAX);
> +	chip->timeout_d = msecs_to_jiffies(TIS_TIMEOUT_D_MAX);
>  	priv->phy_ops = phy_ops;
>  	dev_set_drvdata(&chip->dev, priv);
>  
> -- 
> 2.6.6
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web