Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1445716

Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies
Date 2016-07-18 20:50 +0200
Message-ID <rWlM6-1sH-35@gated-at.bofh.it> (permalink)
References <rUZaV-8gA-1@gated-at.bofh.it> <rWlM6-1sH-13@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw


On Mon, Jul 18, 2016 at 09:45:32PM +0300, Jarkko Sakkinen wrote:
> On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote:
> > tpm_tis_core was missing conversion from msec when assigning
> > max timeouts from constants.
> > 
> > Signed-off-by: Andrey Pronin <apronin@chromium.org>
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Fixes: 41a5e1cf1fe1

Applied.

/Jarkko

> /Jarkko
> 
> > ---
> >  drivers/char/tpm/tpm_tis_core.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> > index 8110b52..fb8c3de 100644
> > --- a/drivers/char/tpm/tpm_tis_core.c
> > +++ b/drivers/char/tpm/tpm_tis_core.c
> > @@ -666,10 +666,10 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
> >  #endif
> >  
> >  	/* Maximum timeouts */
> > -	chip->timeout_a = TIS_TIMEOUT_A_MAX;
> > -	chip->timeout_b = TIS_TIMEOUT_B_MAX;
> > -	chip->timeout_c = TIS_TIMEOUT_C_MAX;
> > -	chip->timeout_d = TIS_TIMEOUT_D_MAX;
> > +	chip->timeout_a = msecs_to_jiffies(TIS_TIMEOUT_A_MAX);
> > +	chip->timeout_b = msecs_to_jiffies(TIS_TIMEOUT_B_MAX);
> > +	chip->timeout_c = msecs_to_jiffies(TIS_TIMEOUT_C_MAX);
> > +	chip->timeout_d = msecs_to_jiffies(TIS_TIMEOUT_D_MAX);
> >  	priv->phy_ops = phy_ops;
> >  	dev_set_drvdata(&chip->dev, priv);
> >  
> > -- 
> > 2.6.6
> > 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Andrey Pronin <apronin@chromium.org> - 2016-07-15 02:30 +0200
  Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-07-15 05:10 +0200
  Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-07-18 20:50 +0200
    Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-07-19 15:00 +0200
  Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-07-18 20:50 +0200
  Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-07-18 20:50 +0200

csiph-web