Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1446365 > unrolled thread
| Started by | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| First post | 2016-07-19 14:00 +0200 |
| Last post | 2016-07-21 17:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Paolo Bonzini <pbonzini@redhat.com> - 2016-07-19 14:00 +0200
Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-07-19 14:30 +0200
Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-21 15:20 +0200
Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Paolo Bonzini <pbonzini@redhat.com> - 2016-07-21 17:00 +0200
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Date | 2016-07-19 14:00 +0200 |
| Subject | [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM |
| Message-ID | <rWBQR-3xG-5@gated-at.bofh.it> |
People complain about the driver saying there's no valid RAPL domains
in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO
if running on a hypervisor, since it is basically stating the obvious.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
First sent out about a year ago. :)
drivers/powercap/intel_rapl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b2766b867b0e..0a0b09910116 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
}
rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
if (!rp->nr_domains) {
- pr_err("no valid rapl domains found in package %d\n", rp->id);
+ printk("%sNo valid RAPL domains found in package %d\n",
+ boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
+ rp->id);
ret = -ENODEV;
goto done;
}
--
2.7.4
[toc] | [next] | [standalone]
| From | Jacob Pan <jacob.jun.pan@linux.intel.com> |
|---|---|
| Date | 2016-07-19 14:30 +0200 |
| Subject | Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM |
| Message-ID | <rWCjU-3Wt-25@gated-at.bofh.it> |
| In reply to | #1446365 |
On Tue, 19 Jul 2016 13:49:57 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> People complain about the driver saying there's no valid RAPL domains
> in a VM, and doing so at KERN_ERR severity. Downgrade this to
> KERN_INFO if running on a hypervisor, since it is basically stating
> the obvious.
>
Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> First sent out about a year ago. :)
>
> drivers/powercap/intel_rapl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/intel_rapl.c
> b/drivers/powercap/intel_rapl.c index b2766b867b0e..0a0b09910116
> 100644 --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct
> rapl_package *rp, int cpu) }
> rp->nr_domains = bitmap_weight(&rp->domain_map,
> RAPL_DOMAIN_MAX); if (!rp->nr_domains) {
> - pr_err("no valid rapl domains found in package
> %d\n", rp->id);
> + printk("%sNo valid RAPL domains found in package
> %d\n",
> + boot_cpu_has(X86_FEATURE_HYPERVISOR) ?
> KERN_INFO : KERN_ERR,
> + rp->id);
> ret = -ENODEV;
> goto done;
> }
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-07-21 15:20 +0200 |
| Message-ID | <rXm3o-7UG-15@gated-at.bofh.it> |
| In reply to | #1446365 |
On Tuesday, July 19, 2016 01:49:57 PM Paolo Bonzini wrote:
> People complain about the driver saying there's no valid RAPL domains
> in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO
> if running on a hypervisor, since it is basically stating the obvious.
>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> First sent out about a year ago. :)
>
> drivers/powercap/intel_rapl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> index b2766b867b0e..0a0b09910116 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
> }
> rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
> if (!rp->nr_domains) {
> - pr_err("no valid rapl domains found in package %d\n", rp->id);
> + printk("%sNo valid RAPL domains found in package %d\n",
> + boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
> + rp->id);
But we print that message with pr_debug() now (as in linux-next).
Do you still want to do anything about that?
> ret = -ENODEV;
> goto done;
> }
>
Thanks,
Rafael
[toc] | [prev] | [next] | [standalone]
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Date | 2016-07-21 17:00 +0200 |
| Subject | Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM |
| Message-ID | <rXnCa-kD-7@gated-at.bofh.it> |
| In reply to | #1447869 |
----- Original Message -----
> From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> To: "Paolo Bonzini" <pbonzini@redhat.com>
> Cc: linux-kernel@vger.kernel.org, "Thomas Renninger" <trenn@suse.de>, "Peter Zijlstra" <peterz@infradead.org>,
> linux-pm@vger.kernel.org, "Jacob Pan" <jacob.jun.pan@linux.intel.com>, "Andy Lutomirski" <luto@amacapital.net>
> Sent: Thursday, July 21, 2016 3:19:28 PM
> Subject: Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM
>
> On Tuesday, July 19, 2016 01:49:57 PM Paolo Bonzini wrote:
> > People complain about the driver saying there's no valid RAPL domains
> > in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO
> > if running on a hypervisor, since it is basically stating the obvious.
> >
> > Suggested-by: Peter Zijlstra <peterz@infradead.org>
> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Cc: Andy Lutomirski <luto@amacapital.net>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > First sent out about a year ago. :)
> >
> > drivers/powercap/intel_rapl.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> > index b2766b867b0e..0a0b09910116 100644
> > --- a/drivers/powercap/intel_rapl.c
> > +++ b/drivers/powercap/intel_rapl.c
> > @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package
> > *rp, int cpu)
> > }
> > rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
> > if (!rp->nr_domains) {
> > - pr_err("no valid rapl domains found in package %d\n", rp->id);
> > + printk("%sNo valid RAPL domains found in package %d\n",
> > + boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
> > + rp->id);
>
> But we print that message with pr_debug() now (as in linux-next).
>
> Do you still want to do anything about that?
Oops, then I guess what is in linux-next is okay.
Thanks,
Paolo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web