Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446365

[PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM

Show all headers | View raw

People complain about the driver saying there's no valid RAPL domains
in a VM, and doing so at KERN_ERR severity.  Downgrade this to KERN_INFO
if running on a hypervisor, since it is basically stating the obvious.

Suggested-by: Peter Zijlstra <peterz@infradead.org>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
	First sent out about a year ago. :)

 drivers/powercap/intel_rapl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b2766b867b0e..0a0b09910116 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
 	}
 	rp->nr_domains = bitmap_weight(&rp->domain_map,	RAPL_DOMAIN_MAX);
 	if (!rp->nr_domains) {
-		pr_err("no valid rapl domains found in package %d\n", rp->id);
+		printk("%sNo valid RAPL domains found in package %d\n",
+		       boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
+		       rp->id);
 		ret = -ENODEV;
 		goto done;
 	}
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Paolo Bonzini <pbonzini@redhat.com> - 2016-07-19 14:00 +0200
  Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains  found in a VM Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-07-19 14:30 +0200
  Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-21 15:20 +0200
    Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains  found in a VM Paolo Bonzini <pbonzini@redhat.com> - 2016-07-21 17:00 +0200

csiph-web