Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445178 > unrolled thread

Re: [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace Byungchul Park <byungchul.park@lge.com> - 2016-07-18 05:30 +0200

#1445178 — Re: [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace

On Fri, Jul 08, 2016 at 04:44:04PM +0200, Frederic Weisbecker wrote:
> Nice improvement but how about doing that with the return value of
> stacktrace_ops::address() instead?
> 
> print_context_stack_bp() uses that for example. This behaviour could
> be extended.

Yes. I will leave the change in print_context_stack_bp() unchanged back.

But frankly speaking, I thought the way to add end_walk improves
its readibility. So I am not sure which way is better. Could you any guys
give me additional opinions about the way to implement? I will follow it.

Thank you,
Byungchul

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web