Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1445178

Re: [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace

From Byungchul Park <byungchul.park@lge.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace
Date 2016-07-18 05:30 +0200
Message-ID <rW7pL-P3-3@gated-at.bofh.it> (permalink)
References <rR9iy-4q7-27@gated-at.bofh.it> <rSFgm-64x-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jul 08, 2016 at 04:44:04PM +0200, Frederic Weisbecker wrote:
> Nice improvement but how about doing that with the return value of
> stacktrace_ops::address() instead?
> 
> print_context_stack_bp() uses that for example. This behaviour could
> be extended.

Yes. I will leave the change in print_context_stack_bp() unchanged back.

But frankly speaking, I thought the way to add end_walk improves
its readibility. So I am not sure which way is better. Could you any guys
give me additional opinions about the way to implement? I will follow it.

Thank you,
Byungchul

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace Byungchul Park <byungchul.park@lge.com> - 2016-07-18 05:30 +0200

csiph-web