Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444449 > unrolled thread

Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFT PATCH v2] [media] exynos4-is: Fix  fimc_is_parse_sensor_config() nodes handling Nicolas Dufresne <nicolas@ndufresne.ca> - 2016-07-15 19:00 +0200
    Re: [RFT PATCH v2] [media] exynos4-is: Fix  fimc_is_parse_sensor_config() nodes handling Nicolas Dufresne <nicolas@ndufresne.ca> - 2016-07-15 19:10 +0200

#1444449 — Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling

[Multipart message — attachments visible in raw view] — view raw

Le jeudi 21 avril 2016 à 09:21 -0400, Javier Martinez Canillas a
écrit :
> Hello Sylwester,
> 
> On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote:
> > The same struct device_node * is used for looking up the I2C
> > sensor, OF
> > graph endpoint and port. So the reference count is incremented but
> > not
> > decremented for the endpoint and port nodes.
> > 
> > Fix this by having separate pointers for each node looked up.
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > 
> 
> Any comments about this patch?

Tested-by: Nicolas Dufresne <nicoas.dufresne@collabora.com>

Note: I could not verify that leak is gone, but I could verify that
this driver is still working properly after the change.

> 
> Best regards,

[toc] | [next] | [standalone]

#1444456

[Multipart message — attachments visible in raw view] — view raw

Le vendredi 15 juillet 2016 à 12:53 -0400, Nicolas Dufresne a écrit :
> Le jeudi 21 avril 2016 à 09:21 -0400, Javier Martinez Canillas a
> écrit :
> > Hello Sylwester,
> > 
> > On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote:
> > > The same struct device_node * is used for looking up the I2C
> > > sensor, OF
> > > graph endpoint and port. So the reference count is incremented
> > > but
> > > not
> > > decremented for the endpoint and port nodes.
> > > 
> > > Fix this by having separate pointers for each node looked up.
> > > 
> > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > > 
> > 
> > Any comments about this patch?
> 
> Tested-by: Nicolas Dufresne <nicoas.dufresne@collabora.com>

There a typo here.

Tested-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> 
> Note: I could not verify that leak is gone, but I could verify that
> this driver is still working properly after the change.
> 
> > 
> > Best regards,

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web