Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling

From	Nicolas Dufresne <nicolas@ndufresne.ca>
Newsgroups	linux.kernel
Subject	Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling
Date	2016-07-15 19:00 +0200
Message-ID	<rVeCZ-QX-13@gated-at.bofh.it> (permalink)
References	<rg1Dj-30H-15@gated-at.bofh.it> <rqmQ9-1lx-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Le jeudi 21 avril 2016 à 09:21 -0400, Javier Martinez Canillas a
écrit :
> Hello Sylwester,
> 
> On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote:
> > The same struct device_node * is used for looking up the I2C
> > sensor, OF
> > graph endpoint and port. So the reference count is incremented but
> > not
> > decremented for the endpoint and port nodes.
> > 
> > Fix this by having separate pointers for each node looked up.
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > 
> 
> Any comments about this patch?

Tested-by: Nicolas Dufresne <nicoas.dufresne@collabora.com>

Note: I could not verify that leak is gone, but I could verify that
this driver is still working properly after the change.

> 
> Best regards,

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFT PATCH v2] [media] exynos4-is: Fix  fimc_is_parse_sensor_config() nodes handling Nicolas Dufresne <nicolas@ndufresne.ca> - 2016-07-15 19:00 +0200
  Re: [RFT PATCH v2] [media] exynos4-is: Fix  fimc_is_parse_sensor_config() nodes handling Nicolas Dufresne <nicolas@ndufresne.ca> - 2016-07-15 19:10 +0200

csiph-web