Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444272 > unrolled thread
| Started by | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| First post | 2016-07-15 14:50 +0200 |
| Last post | 2016-07-15 23:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-15 14:50 +0200
Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels Steve Longerbeam <steve_longerbeam@mentor.com> - 2016-07-15 23:40 +0200
| From | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| Date | 2016-07-15 14:50 +0200 |
| Subject | Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels |
| Message-ID | <rVaJ4-6Xs-19@gated-at.bofh.it> |
Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam:
> Adds the VDIC field input IDMAC channels. These channels
> transfer fields F(n-1), F(n), and F(N+1) from memory to
> the VDIC (channels 8, 9, 10 respectively).
>
> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> ---
> include/video/imx-ipu-v3.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h
> index 586979e..2302fc5 100644
> --- a/include/video/imx-ipu-v3.h
> +++ b/include/video/imx-ipu-v3.h
> @@ -107,6 +107,9 @@ enum ipu_channel_irq {
> #define IPUV3_CHANNEL_CSI2 2
> #define IPUV3_CHANNEL_CSI3 3
> #define IPUV3_CHANNEL_VDI_MEM_IC_VF 5
> +#define IPUV3_CHANNEL_MEM_VDI_P 8
> +#define IPUV3_CHANNEL_MEM_VDI 9
> +#define IPUV3_CHANNEL_MEM_VDI_N 10
I would prefer the names to be just a bit more descriptive:
#define IPUV3_CHANNEL_MEM_VDI_PREV 8
#define IPUV3_CHANNEL_MEM_VDI_CUR 9
#define IPUV3_CHANNEL_MEM_VDI_NEXT 10
The reference manual states that the purposes of these channels are
"Previous field", "Current field", and "Next field" input to the VDIC,
respectively.
regards
Philipp
[toc] | [next] | [standalone]
| From | Steve Longerbeam <steve_longerbeam@mentor.com> |
|---|---|
| Date | 2016-07-15 23:40 +0200 |
| Message-ID | <rViZX-3Bi-3@gated-at.bofh.it> |
| In reply to | #1444272 |
On 07/15/2016 05:45 AM, Philipp Zabel wrote:
> Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam:
>> Adds the VDIC field input IDMAC channels. These channels
>> transfer fields F(n-1), F(n), and F(N+1) from memory to
>> the VDIC (channels 8, 9, 10 respectively).
>>
>> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
>> ---
>> include/video/imx-ipu-v3.h | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h
>> index 586979e..2302fc5 100644
>> --- a/include/video/imx-ipu-v3.h
>> +++ b/include/video/imx-ipu-v3.h
>> @@ -107,6 +107,9 @@ enum ipu_channel_irq {
>> #define IPUV3_CHANNEL_CSI2 2
>> #define IPUV3_CHANNEL_CSI3 3
>> #define IPUV3_CHANNEL_VDI_MEM_IC_VF 5
>> +#define IPUV3_CHANNEL_MEM_VDI_P 8
>> +#define IPUV3_CHANNEL_MEM_VDI 9
>> +#define IPUV3_CHANNEL_MEM_VDI_N 10
> I would prefer the names to be just a bit more descriptive:
>
> #define IPUV3_CHANNEL_MEM_VDI_PREV 8
> #define IPUV3_CHANNEL_MEM_VDI_CUR 9
> #define IPUV3_CHANNEL_MEM_VDI_NEXT 10
>
> The reference manual states that the purposes of these channels are
> "Previous field", "Current field", and "Next field" input to the VDIC,
> respectively.
right. Ok I will make that change in next version.
Steve
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web