Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444266 > unrolled thread
| Started by | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| First post | 2016-07-15 14:50 +0200 |
| Last post | 2016-07-15 23:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src() Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-15 14:50 +0200
Re: [PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src() Steve Longerbeam <steve_longerbeam@mentor.com> - 2016-07-15 23:50 +0200
| From | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| Date | 2016-07-15 14:50 +0200 |
| Subject | Re: [PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src() |
| Message-ID | <rVaJ3-6Xs-7@gated-at.bofh.it> |
Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam:
> Adds ipu_csi_set_src() which is just a wrapper around
> ipu_set_csi_src_mux().
>
> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> ---
> drivers/gpu/ipu-v3/ipu-csi.c | 8 ++++++++
> include/video/imx-ipu-v3.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c
> index 06631ac..336dc06 100644
> --- a/drivers/gpu/ipu-v3/ipu-csi.c
> +++ b/drivers/gpu/ipu-v3/ipu-csi.c
> @@ -609,6 +609,14 @@ int ipu_csi_set_skip_smfc(struct ipu_csi *csi, u32 skip,
> }
> EXPORT_SYMBOL_GPL(ipu_csi_set_skip_smfc);
>
> +int ipu_csi_set_src(struct ipu_csi *csi, u32 vc, bool select_mipi_csi2)
vc is unused.
> +{
> + ipu_set_csi_src_mux(csi->ipu, csi->id, select_mipi_csi2);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(ipu_csi_set_src);
> +
Couldn't you just replace ipu_set_csi_src_mux?
regards
Philipp
[toc] | [next] | [standalone]
| From | Steve Longerbeam <steve_longerbeam@mentor.com> |
|---|---|
| Date | 2016-07-15 23:50 +0200 |
| Message-ID | <rVj9E-3EM-31@gated-at.bofh.it> |
| In reply to | #1444266 |
On 07/15/2016 05:49 AM, Philipp Zabel wrote:
> Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam:
>
>> +{
>> + ipu_set_csi_src_mux(csi->ipu, csi->id, select_mipi_csi2);
>> +
>> + return 0;
>> +}
>> +EXPORT_SYMBOL_GPL(ipu_csi_set_src);
>> +
> Couldn't you just replace ipu_set_csi_src_mux?
Yeah. I guess I created this as a matter of code convenience,
but not worth exporting another function. I will remove this patch
in next version.
Steve
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web