Re: [PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src()

From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src()
Date	2016-07-15 14:50 +0200
Message-ID	<rVaJ3-6Xs-7@gated-at.bofh.it> (permalink)
References	<rSqAF-51z-3@gated-at.bofh.it> <rSqAG-51z-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam:
> Adds ipu_csi_set_src() which is just a wrapper around
> ipu_set_csi_src_mux().
> 
> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> ---
>  drivers/gpu/ipu-v3/ipu-csi.c | 8 ++++++++
>  include/video/imx-ipu-v3.h   | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c
> index 06631ac..336dc06 100644
> --- a/drivers/gpu/ipu-v3/ipu-csi.c
> +++ b/drivers/gpu/ipu-v3/ipu-csi.c
> @@ -609,6 +609,14 @@ int ipu_csi_set_skip_smfc(struct ipu_csi *csi, u32 skip,
>  }
>  EXPORT_SYMBOL_GPL(ipu_csi_set_skip_smfc);
>  
> +int ipu_csi_set_src(struct ipu_csi *csi, u32 vc, bool select_mipi_csi2)

vc is unused.

> +{
> +	ipu_set_csi_src_mux(csi->ipu, csi->id, select_mipi_csi2);
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(ipu_csi_set_src);
> +

Couldn't you just replace ipu_set_csi_src_mux?

regards
Philipp

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src() Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-15 14:50 +0200
  Re: [PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src() Steve Longerbeam <steve_longerbeam@mentor.com> - 2016-07-15 23:50 +0200

csiph-web