Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1442748 > unrolled thread
| Started by | Jon Mason <jon.mason@broadcom.com> |
|---|---|
| First post | 2016-07-13 20:30 +0200 |
| Last post | 2016-07-14 20:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: dts: NSP: Correct RAM amount for BCM958625HR board Jon Mason <jon.mason@broadcom.com> - 2016-07-13 20:30 +0200
Re: [PATCH] ARM: dts: NSP: Correct RAM amount for BCM958625HR board Florian Fainelli <f.fainelli@gmail.com> - 2016-07-13 23:30 +0200
Re: [PATCH] ARM: dts: NSP: Correct RAM amount for BCM958625HR board Jon Mason <jon.mason@broadcom.com> - 2016-07-14 20:20 +0200
| From | Jon Mason <jon.mason@broadcom.com> |
|---|---|
| Date | 2016-07-13 20:30 +0200 |
| Subject | [PATCH] ARM: dts: NSP: Correct RAM amount for BCM958625HR board |
| Message-ID | <rUx50-6Li-31@gated-at.bofh.it> |
The BCM958625HR board has 2GB of RAM available. Increase the amount
from 512MB to 2GB and add the device type to the memory entry.
Signed-off-by: Jon Mason <jon.mason@broadcom.com>
---
arch/arm/boot/dts/bcm958625hr.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
index 4239e58..66c658a 100644
--- a/arch/arm/boot/dts/bcm958625hr.dts
+++ b/arch/arm/boot/dts/bcm958625hr.dts
@@ -47,7 +47,8 @@
};
memory {
- reg = <0x60000000 0x20000000>;
+ device_type = "memory";
+ reg = <0x60000000 0x40000000>;
};
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2016-07-13 23:30 +0200 |
| Message-ID | <rUzTd-b7-43@gated-at.bofh.it> |
| In reply to | #1442748 |
On 07/13/2016 11:18 AM, Jon Mason wrote:
> The BCM958625HR board has 2GB of RAM available. Increase the amount
> from 512MB to 2GB and add the device type to the memory entry.
>
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> ---
> arch/arm/boot/dts/bcm958625hr.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
> index 4239e58..66c658a 100644
> --- a/arch/arm/boot/dts/bcm958625hr.dts
> +++ b/arch/arm/boot/dts/bcm958625hr.dts
> @@ -47,7 +47,8 @@
> };
>
> memory {
> - reg = <0x60000000 0x20000000>;
> + device_type = "memory";
> + reg = <0x60000000 0x40000000>;
That's just one 1GB, did you intend to provide 0x8000_0000 instead here?
--
Florian
[toc] | [prev] | [next] | [standalone]
| From | Jon Mason <jon.mason@broadcom.com> |
|---|---|
| Date | 2016-07-14 20:20 +0200 |
| Message-ID | <rUToS-4Fx-17@gated-at.bofh.it> |
| In reply to | #1442876 |
On Wed, Jul 13, 2016 at 5:23 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 07/13/2016 11:18 AM, Jon Mason wrote:
>> The BCM958625HR board has 2GB of RAM available. Increase the amount
>> from 512MB to 2GB and add the device type to the memory entry.
>>
>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>> ---
>> arch/arm/boot/dts/bcm958625hr.dts | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
>> index 4239e58..66c658a 100644
>> --- a/arch/arm/boot/dts/bcm958625hr.dts
>> +++ b/arch/arm/boot/dts/bcm958625hr.dts
>> @@ -47,7 +47,8 @@
>> };
>>
>> memory {
>> - reg = <0x60000000 0x20000000>;
>> + device_type = "memory";
>> + reg = <0x60000000 0x40000000>;
>
> That's just one 1GB, did you intend to provide 0x8000_0000 instead here?
Good catch! I'll fix that up in v2 (and add a "Fixes:" referencing
the original patch).
Thanks,
Jon
> --
> Florian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web