Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1441256 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-07-12 13:20 +0200 |
| Last post | 2016-07-18 22:20 +0200 |
| Articles | 5 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time Colin King <colin.king@canonical.com> - 2016-07-12 13:20 +0200
Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-07-12 13:30 +0200
Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time Colin Ian King <colin.king@canonical.com> - 2016-07-12 13:40 +0200
Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time Tejun Heo <tj@kernel.org> - 2016-07-12 17:10 +0200
Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-07-18 22:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-07-12 13:20 +0200 |
| Subject | [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time |
| Message-ID | <rU3Tj-48p-3@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
According to the HPT366 data sheet, PCI config space dword 0x40-0x43
bits 11:8 specify the primary drive cmd_high_time, however,
currently just 3 bits of the 4 are being used because the mask
is 0x700 and not 0x0f00. Fix the mask, allowing for the 40MHz clock
to be detected.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/ata/pata_hpt366.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c
index e5fb752..a219a50 100644
--- a/drivers/ata/pata_hpt366.c
+++ b/drivers/ata/pata_hpt366.c
@@ -368,7 +368,7 @@ static int hpt36x_init_one(struct pci_dev *dev, const struct pci_device_id *id)
/* PCI clocking determines the ATA timing values to use */
/* info_hpt366 is safe against re-entry so we can scribble on it */
- switch ((reg1 & 0x700) >> 8) {
+ switch ((reg1 & 0xf00) >> 8) {
case 9:
hpriv = &hpt366_40;
break;
--
2.8.1
[toc] | [next] | [standalone]
| From | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
|---|---|
| Date | 2016-07-12 13:30 +0200 |
| Subject | Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time |
| Message-ID | <rU430-4c1-15@gated-at.bofh.it> |
| In reply to | #1441256 |
Hi,
On Tuesday, July 12, 2016 12:16:19 PM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
> bits 11:8 specify the primary drive cmd_high_time, however,
> currently just 3 bits of the 4 are being used because the mask
> is 0x700 and not 0x0f00. Fix the mask, allowing for the 40MHz clock
> to be detected.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Thanks for the patch, could you also fix also the old driver
(drivers/ide/hpt366.c)?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/ata/pata_hpt366.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c
> index e5fb752..a219a50 100644
> --- a/drivers/ata/pata_hpt366.c
> +++ b/drivers/ata/pata_hpt366.c
> @@ -368,7 +368,7 @@ static int hpt36x_init_one(struct pci_dev *dev, const struct pci_device_id *id)
>
> /* PCI clocking determines the ATA timing values to use */
> /* info_hpt366 is safe against re-entry so we can scribble on it */
> - switch ((reg1 & 0x700) >> 8) {
> + switch ((reg1 & 0xf00) >> 8) {
> case 9:
> hpriv = &hpt366_40;
> break;
[toc] | [prev] | [next] | [standalone]
| From | Colin Ian King <colin.king@canonical.com> |
|---|---|
| Date | 2016-07-12 13:40 +0200 |
| Subject | Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time |
| Message-ID | <rU4cG-4gU-23@gated-at.bofh.it> |
| In reply to | #1441264 |
On 12/07/16 12:27, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Tuesday, July 12, 2016 12:16:19 PM Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
>> bits 11:8 specify the primary drive cmd_high_time, however,
>> currently just 3 bits of the 4 are being used because the mask
>> is 0x700 and not 0x0f00. Fix the mask, allowing for the 40MHz clock
>> to be detected.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> Thanks for the patch, could you also fix also the old driver
> (drivers/ide/hpt366.c)?
Yep, patch already sent.
https://lkml.org/lkml/2016/7/12/199
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>> ---
>> drivers/ata/pata_hpt366.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c
>> index e5fb752..a219a50 100644
>> --- a/drivers/ata/pata_hpt366.c
>> +++ b/drivers/ata/pata_hpt366.c
>> @@ -368,7 +368,7 @@ static int hpt36x_init_one(struct pci_dev *dev, const struct pci_device_id *id)
>>
>> /* PCI clocking determines the ATA timing values to use */
>> /* info_hpt366 is safe against re-entry so we can scribble on it */
>> - switch ((reg1 & 0x700) >> 8) {
>> + switch ((reg1 & 0xf00) >> 8) {
>> case 9:
>> hpriv = &hpt366_40;
>> break;
>
[toc] | [prev] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2016-07-12 17:10 +0200 |
| Subject | Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time |
| Message-ID | <rU7tV-6CN-29@gated-at.bofh.it> |
| In reply to | #1441256 |
On Tue, Jul 12, 2016 at 12:16:19PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > According to the HPT366 data sheet, PCI config space dword 0x40-0x43 > bits 11:8 specify the primary drive cmd_high_time, however, > currently just 3 bits of the 4 are being used because the mask > is 0x700 and not 0x0f00. Fix the mask, allowing for the 40MHz clock > to be detected. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to libata/for-4.8. Thanks. -- tejun
[toc] | [prev] | [next] | [standalone]
| From | One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> |
|---|---|
| Date | 2016-07-18 22:20 +0200 |
| Subject | Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time |
| Message-ID | <rWnbc-2v5-23@gated-at.bofh.it> |
| In reply to | #1441256 |
On Tue, 12 Jul 2016 12:16:19 +0100 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > According to the HPT366 data sheet, PCI config space dword 0x40-0x43 > bits 11:8 specify the primary drive cmd_high_time, however, > currently just 3 bits of the 4 are being used because the mask > is 0x700 and not 0x0f00. Fix the mask, allowing for the 40MHz clock > to be detected. Is this tested on real hardware ? I learned long ago never to blindly trust IDE data sheets. It looks right but if anyone actually has a 40MHz PCI bus box with an HPT366 it would be good to test. Alan
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web