Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time

From	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time
Date	2016-07-18 22:20 +0200
Message-ID	<rWnbc-2v5-23@gated-at.bofh.it> (permalink)
References	<rU3Tj-48p-3@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

On Tue, 12 Jul 2016 12:16:19 +0100
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
> bits 11:8 specify the primary drive cmd_high_time, however,
> currently just 3 bits of the 4 are being used because the mask
> is 0x700 and not 0x0f00.  Fix the mask, allowing for the 40MHz clock
> to be detected.

Is this tested on real hardware ? I learned long ago never to blindly
trust IDE data sheets. It looks right but if anyone actually has a 40MHz
PCI bus box with an HPT366 it would be good to test.

Alan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time Colin King <colin.king@canonical.com> - 2016-07-12 13:20 +0200
  Re: [PATCH] ata: hpt366: fix incorrect mask when checking at  cmd_high_time Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-07-12 13:30 +0200
    Re: [PATCH] ata: hpt366: fix incorrect mask when checking at  cmd_high_time Colin Ian King <colin.king@canonical.com> - 2016-07-12 13:40 +0200
  Re: [PATCH] ata: hpt366: fix incorrect mask when checking at  cmd_high_time Tejun Heo <tj@kernel.org> - 2016-07-12 17:10 +0200
  Re: [PATCH] ata: hpt366: fix incorrect mask when checking at  cmd_high_time One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-07-18 22:20 +0200

csiph-web