Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440865 > unrolled thread
| Started by | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| First post | 2016-07-11 22:40 +0200 |
| Last post | 2016-07-11 23:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] clk: sunxi-ng: h3: Fix audio clock divider offset Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-11 22:40 +0200
Re: [PATCH 1/2] clk: sunxi-ng: h3: Fix audio clock divider offset Michael Turquette <mturquette@baylibre.com> - 2016-07-11 23:40 +0200
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-07-11 22:40 +0200 |
| Subject | [PATCH 1/2] clk: sunxi-ng: h3: Fix audio clock divider offset |
| Message-ID | <rTQ9H-3wF-3@gated-at.bofh.it> |
The code had a typo and got the wrong offset for the hardcoded divider, fix that. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Reported-by: Jean-Francois Moine <moinejf@free.fr> Reported-by: Chen-Yu Tsai <wens@csie.org> --- drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-h3.c b/drivers/clk/sunxi-ng/ccu-sun8i-h3.c index bcc0a95549d3..9af359544110 100644 --- a/drivers/clk/sunxi-ng/ccu-sun8i-h3.c +++ b/drivers/clk/sunxi-ng/ccu-sun8i-h3.c @@ -817,8 +817,8 @@ static void __init sun8i_h3_ccu_setup(struct device_node *node) /* Force the PLL-Audio-1x divider to 4 */ val = readl(reg + SUN8I_H3_PLL_AUDIO_REG); - val &= ~GENMASK(4, 0); - writel(val | 3, reg + SUN8I_H3_PLL_AUDIO_REG); + val &= ~GENMASK(19, 16); + writel(val | (3 << 16), reg + SUN8I_H3_PLL_AUDIO_REG); sunxi_ccu_probe(node, reg, &sun8i_h3_ccu_desc); } -- 2.9.0
[toc] | [next] | [standalone]
| From | Michael Turquette <mturquette@baylibre.com> |
|---|---|
| Date | 2016-07-11 23:40 +0200 |
| Message-ID | <rTR5M-4a4-17@gated-at.bofh.it> |
| In reply to | #1440865 |
Quoting Maxime Ripard (2016-07-11 13:34:47) > The code had a typo and got the wrong offset for the hardcoded divider, fix > that. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > Reported-by: Jean-Francois Moine <moinejf@free.fr> > Reported-by: Chen-Yu Tsai <wens@csie.org> Applied. Regards, Mike > --- > drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-h3.c b/drivers/clk/sunxi-ng/ccu-sun8i-h3.c > index bcc0a95549d3..9af359544110 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun8i-h3.c > +++ b/drivers/clk/sunxi-ng/ccu-sun8i-h3.c > @@ -817,8 +817,8 @@ static void __init sun8i_h3_ccu_setup(struct device_node *node) > > /* Force the PLL-Audio-1x divider to 4 */ > val = readl(reg + SUN8I_H3_PLL_AUDIO_REG); > - val &= ~GENMASK(4, 0); > - writel(val | 3, reg + SUN8I_H3_PLL_AUDIO_REG); > + val &= ~GENMASK(19, 16); > + writel(val | (3 << 16), reg + SUN8I_H3_PLL_AUDIO_REG); > > sunxi_ccu_probe(node, reg, &sun8i_h3_ccu_desc); > } > -- > 2.9.0 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web