Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1440922

Re: [PATCH 1/2] clk: sunxi-ng: h3: Fix audio clock divider offset

From Michael Turquette <mturquette@baylibre.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] clk: sunxi-ng: h3: Fix audio clock divider offset
Date 2016-07-11 23:40 +0200
Message-ID <rTR5M-4a4-17@gated-at.bofh.it> (permalink)
References <rTQ9H-3wF-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Quoting Maxime Ripard (2016-07-11 13:34:47)
> The code had a typo and got the wrong offset for the hardcoded divider, fix
> that.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reported-by: Jean-Francois Moine <moinejf@free.fr>
> Reported-by: Chen-Yu Tsai <wens@csie.org>

Applied.

Regards,
Mike

> ---
>  drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-h3.c b/drivers/clk/sunxi-ng/ccu-sun8i-h3.c
> index bcc0a95549d3..9af359544110 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun8i-h3.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun8i-h3.c
> @@ -817,8 +817,8 @@ static void __init sun8i_h3_ccu_setup(struct device_node *node)
>  
>         /* Force the PLL-Audio-1x divider to 4 */
>         val = readl(reg + SUN8I_H3_PLL_AUDIO_REG);
> -       val &= ~GENMASK(4, 0);
> -       writel(val | 3, reg + SUN8I_H3_PLL_AUDIO_REG);
> +       val &= ~GENMASK(19, 16);
> +       writel(val | (3 << 16), reg + SUN8I_H3_PLL_AUDIO_REG);
>  
>         sunxi_ccu_probe(node, reg, &sun8i_h3_ccu_desc);
>  }
> -- 
> 2.9.0
> 

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] clk: sunxi-ng: h3: Fix audio clock divider offset Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-11 22:40 +0200
  Re: [PATCH 1/2] clk: sunxi-ng: h3: Fix audio clock divider offset Michael Turquette <mturquette@baylibre.com> - 2016-07-11 23:40 +0200

csiph-web