Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440836 > unrolled thread
| Started by | "Singh, Krishneil K" <krishneil.k.singh@intel.com> |
|---|---|
| First post | 2016-07-11 21:30 +0200 |
| Last post | 2016-07-11 21:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
RE: [Intel-wired-lan] [PATCH] net: ethernet: intel: fm10k: Remove create_workqueue "Singh, Krishneil K" <krishneil.k.singh@intel.com> - 2016-07-11 21:30 +0200
| From | "Singh, Krishneil K" <krishneil.k.singh@intel.com> |
|---|---|
| Date | 2016-07-11 21:30 +0200 |
| Subject | RE: [Intel-wired-lan] [PATCH] net: ethernet: intel: fm10k: Remove create_workqueue |
| Message-ID | <rTP3X-2RG-5@gated-at.bofh.it> |
-----Original Message----- From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On Behalf Of Bhaktipriya Shridhar Sent: Wednesday, June 1, 2016 8:40 AM To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com> Cc: Tejun Heo <tj@kernel.org>; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org Subject: [Intel-wired-lan] [PATCH] net: ethernet: intel: fm10k: Remove create_workqueue alloc_workqueue replaces deprecated create_workqueue(). A dedicated workqueue has been used since the workitem (viz fm10k_service_task, which manages and runs other subtasks) is involved in normal device operation and requires forward progress under memory pressure. create_workqueue has been replaced with alloc_workqueue with max_active as 0 since there is no need for throttling the number of active work items. Since network devices may be used in memory reclaim path, WQ_MEM_RECLAIM has been set to guarantee forward progress. flush_workqueue is unnecessary since destroy_workqueue() itself calls drain_workqueue() which flushes repeatedly till the workqueue becomes empty. Hence the call to flush_workqueue() has been dropped. Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> --- Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Back to top | Article view | linux.kernel
csiph-web