RE: [Intel-wired-lan] [PATCH] net: ethernet: intel: fm10k: Remove create_workqueue

From	"Singh, Krishneil K" <krishneil.k.singh@intel.com>
Newsgroups	linux.kernel
Subject	RE: [Intel-wired-lan] [PATCH] net: ethernet: intel: fm10k: Remove create_workqueue
Date	2016-07-11 21:30 +0200
Message-ID	<rTP3X-2RG-5@gated-at.bofh.it> (permalink)
References	<rFgz8-1Kx-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On Behalf Of Bhaktipriya Shridhar
Sent: Wednesday, June 1, 2016 8:40 AM
To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
Cc: Tejun Heo <tj@kernel.org>; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org
Subject: [Intel-wired-lan] [PATCH] net: ethernet: intel: fm10k: Remove create_workqueue

alloc_workqueue replaces deprecated create_workqueue().

A dedicated workqueue has been used since the workitem (viz fm10k_service_task, which manages and runs other subtasks) is involved in normal device operation and requires forward progress under memory pressure.

create_workqueue has been replaced with alloc_workqueue with max_active as 0 since there is no need for throttling the number of active work items.

Since network devices may be used in memory reclaim path, WQ_MEM_RECLAIM has been set to guarantee forward progress.

flush_workqueue is unnecessary since destroy_workqueue() itself calls
drain_workqueue() which flushes repeatedly till the workqueue becomes empty. Hence the call to flush_workqueue() has been dropped.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---

Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [Intel-wired-lan] [PATCH] net: ethernet: intel: fm10k: Remove  create_workqueue "Singh, Krishneil K" <krishneil.k.singh@intel.com> - 2016-07-11 21:30 +0200

csiph-web