Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1439989 > unrolled thread

[PATCH] drm/vc4: remove redundant ret status check

Back to article view | Back to linux.kernel

Contents

  [PATCH] drm/vc4: remove redundant ret status check Colin King <colin.king@canonical.com> - 2016-07-10 00:30 +0200
    Re: [PATCH] drm/vc4: remove redundant ret status check Eric Anholt <eric@anholt.net> - 2016-07-12 02:30 +0200

#1439989 — [PATCH] drm/vc4: remove redundant ret status check

From: Colin Ian King <colin.king@canonical.com>

At the current point where ret is being checked for non-zero it has
not changed since it was initialized to zero, hence the check and the
label unref are redundant and can be removed.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/vc4/vc4_drv.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 54d0471..0e4cf27 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -195,8 +195,6 @@ static int vc4_drm_bind(struct device *dev)
 	vc4_bo_cache_init(drm);
 
 	drm_mode_config_init(drm);
-	if (ret)
-		goto unref;
 
 	vc4_gem_init(drm);
 
@@ -218,7 +216,6 @@ unbind_all:
 	component_unbind_all(dev, drm);
 gem_destroy:
 	vc4_gem_destroy(drm);
-unref:
 	drm_dev_unref(drm);
 	vc4_bo_cache_destroy(drm);
 	return ret;
-- 
2.8.1

[toc] | [next] | [standalone]

#1440979

[Multipart message — attachments visible in raw view] — view raw

Colin King <colin.king@canonical.com> writes:

> From: Colin Ian King <colin.king@canonical.com>
>
> At the current point where ret is being checked for non-zero it has
> not changed since it was initialized to zero, hence the check and the
> label unref are redundant and can be removed.

Reviewed-by: Eric Anholt <eric@anholt.net>

I'll put this in my next pull request.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web