Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438250 > unrolled thread

[PATCH] xen-blkback: constify instance of "struct attribute_group"

Started by"Jan Beulich" <JBeulich@suse.com>
First post2016-07-07 09:50 +0200
Last post2016-07-08 16:00 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] xen-blkback: constify instance of "struct  attribute_group" "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 09:50 +0200
    Re: [PATCH] xen-blkback: constify instance of "struct  attribute_group" Roger Pau Monne <roger.pau@citrix.com> - 2016-07-07 11:50 +0200
      Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct  attribute_group" Andrew Cooper <andrew.cooper3@citrix.com> - 2016-07-07 12:00 +0200
        Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct  attribute_group" Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-07 17:40 +0200
          Re: [Xen-devel] [PATCH] xen-blkback: constify instance of  "struct attribute_group" "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 18:00 +0200
            Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct  attribute_group" Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-08 16:00 +0200

#1438250 — [PATCH] xen-blkback: constify instance of "struct attribute_group"

From"Jan Beulich" <JBeulich@suse.com>
Date2016-07-07 09:50 +0200
Subject[PATCH] xen-blkback: constify instance of "struct attribute_group"
Message-ID<rScem-3Vx-27@gated-at.bofh.it>
The functions such get passed to have been taking pointers to const
since at least 2.6.16.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
 drivers/block/xen-blkback/xenbus.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 4.7-rc6-xen.orig/drivers/block/xen-blkback/xenbus.c
+++ 4.7-rc6-xen/drivers/block/xen-blkback/xenbus.c
@@ -379,7 +379,7 @@ static struct attribute *xen_vbdstat_att
 	NULL
 };
 
-static struct attribute_group xen_vbdstat_group = {
+static const struct attribute_group xen_vbdstat_group = {
 	.name = "statistics",
 	.attrs = xen_vbdstat_attrs,
 };

[toc] | [next] | [standalone]

#1438465

FromRoger Pau Monne <roger.pau@citrix.com>
Date2016-07-07 11:50 +0200
Message-ID<rSe6u-59g-7@gated-at.bofh.it>
In reply to#1438250
On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> The functions such get passed to have been taking pointers to const
> since at least 2.6.16.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Although the wording in the commit message looks weird to me, but I'm not a 
native speaker anyway.

Roger.

[toc] | [prev] | [next] | [standalone]

#1438482 — Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

FromAndrew Cooper <andrew.cooper3@citrix.com>
Date2016-07-07 12:00 +0200
SubjectRe: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
Message-ID<rSeg9-5cz-21@gated-at.bofh.it>
In reply to#1438465
On 07/07/16 10:45, Roger Pau Monne wrote:
> On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
>> The functions such get passed to have been taking pointers to const
>> since at least 2.6.16.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Although the wording in the commit message looks weird to me, but I'm not a 
> native speaker anyway.

As a native speaker, I can't parse it either.

I think s/such/these/ is needed.

~Andrew

[toc] | [prev] | [next] | [standalone]

#1438682 — Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

FromKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date2016-07-07 17:40 +0200
SubjectRe: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
Message-ID<rSjzc-nu-27@gated-at.bofh.it>
In reply to#1438482
On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> On 07/07/16 10:45, Roger Pau Monne wrote:
> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> The functions such get passed to have been taking pointers to const
> >> since at least 2.6.16.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >
> > Although the wording in the commit message looks weird to me, but I'm not a 
> > native speaker anyway.
> 
> As a native speaker, I can't parse it either.
> 
> I think s/such/these/ is needed.

The functions such as these have been taking pointers to const
since at least 2.6.16. 

?
> 
> ~Andrew
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

[toc] | [prev] | [next] | [standalone]

#1438694 — Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

From"Jan Beulich" <JBeulich@suse.com>
Date2016-07-07 18:00 +0200
SubjectRe: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
Message-ID<rSjSy-vy-27@gated-at.bofh.it>
In reply to#1438682
>>> On 07.07.16 at 17:37, <konrad.wilk@oracle.com> wrote:
> On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
>> On 07/07/16 10:45, Roger Pau Monne wrote:
>> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
>> >> The functions such get passed to have been taking pointers to const
>> >> since at least 2.6.16.
>> >>
>> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>> >
>> > Although the wording in the commit message looks weird to me, but I'm not a 
> 
>> > native speaker anyway.
>> 
>> As a native speaker, I can't parse it either.
>> 
>> I think s/such/these/ is needed.
> 
> The functions such as these have been taking pointers to const
> since at least 2.6.16. 

I had taken Andrew's suggestion literally and changed it to "The
functions these get passed to have been taking pointers to const
since at least 2.6.16" for a possible (if needed) resubmission.

Jan

[toc] | [prev] | [next] | [standalone]

#1439470 — Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

FromKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date2016-07-08 16:00 +0200
SubjectRe: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
Message-ID<rSEtX-5vY-1@gated-at.bofh.it>
In reply to#1438694
On Thu, Jul 07, 2016 at 09:57:10AM -0600, Jan Beulich wrote:
> >>> On 07.07.16 at 17:37, <konrad.wilk@oracle.com> wrote:
> > On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> >> On 07/07/16 10:45, Roger Pau Monne wrote:
> >> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> >> The functions such get passed to have been taking pointers to const
> >> >> since at least 2.6.16.
> >> >>
> >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >> >
> >> > Although the wording in the commit message looks weird to me, but I'm not a 
> > 
> >> > native speaker anyway.
> >> 
> >> As a native speaker, I can't parse it either.
> >> 
> >> I think s/such/these/ is needed.
> > 
> > The functions such as these have been taking pointers to const
> > since at least 2.6.16. 
> 
> I had taken Andrew's suggestion literally and changed it to "The
> functions these get passed to have been taking pointers to const
> since at least 2.6.16" for a possible (if needed) resubmission.

No need to resubmit. I will use Andrew's suggestion.
> 
> Jan

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web