Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1438482

Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

From Andrew Cooper <andrew.cooper3@citrix.com>
Newsgroups linux.kernel
Subject Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
Date 2016-07-07 12:00 +0200
Message-ID <rSeg9-5cz-21@gated-at.bofh.it> (permalink)
References <rScem-3Vx-27@gated-at.bofh.it> <rSe6u-59g-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 07/07/16 10:45, Roger Pau Monne wrote:
> On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
>> The functions such get passed to have been taking pointers to const
>> since at least 2.6.16.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Although the wording in the commit message looks weird to me, but I'm not a 
> native speaker anyway.

As a native speaker, I can't parse it either.

I think s/such/these/ is needed.

~Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] xen-blkback: constify instance of "struct  attribute_group" "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 09:50 +0200
  Re: [PATCH] xen-blkback: constify instance of "struct  attribute_group" Roger Pau Monne <roger.pau@citrix.com> - 2016-07-07 11:50 +0200
    Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct  attribute_group" Andrew Cooper <andrew.cooper3@citrix.com> - 2016-07-07 12:00 +0200
      Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct  attribute_group" Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-07 17:40 +0200
        Re: [Xen-devel] [PATCH] xen-blkback: constify instance of  "struct attribute_group" "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 18:00 +0200
          Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct  attribute_group" Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-08 16:00 +0200

csiph-web