Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1439488 > unrolled thread

[RFC][PATCH 4/7] perf/x86/intel: Remove redundant test from intel_pmu_lbr_add()

Started byPeter Zijlstra <peterz@infradead.org>
First post2016-07-08 16:10 +0200
Last post2016-07-08 16:10 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [RFC][PATCH 4/7] perf/x86/intel: Remove redundant test from intel_pmu_lbr_add() Peter Zijlstra <peterz@infradead.org> - 2016-07-08 16:10 +0200

#1439488 — [RFC][PATCH 4/7] perf/x86/intel: Remove redundant test from intel_pmu_lbr_add()

FromPeter Zijlstra <peterz@infradead.org>
Date2016-07-08 16:10 +0200
Subject[RFC][PATCH 4/7] perf/x86/intel: Remove redundant test from intel_pmu_lbr_add()
Message-ID<rSEDE-5P7-35@gated-at.bofh.it>
By the time we call pmu::add(), event->ctx must be set, and we
even already rely on this, so remove that test from
intel_pmu_lbr_add().

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 arch/x86/events/intel/lbr.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/arch/x86/events/intel/lbr.c
+++ b/arch/x86/events/intel/lbr.c
@@ -440,8 +440,7 @@ void intel_pmu_lbr_add(struct perf_event
 	}
 	cpuc->br_sel = event->hw.branch_reg.reg;
 
-	if (branch_user_callstack(cpuc->br_sel) && event->ctx &&
-					event->ctx->task_ctx_data) {
+	if (branch_user_callstack(cpuc->br_sel) && event->ctx->task_ctx_data) {
 		task_ctx = event->ctx->task_ctx_data;
 		task_ctx->lbr_callstack_users++;
 	}

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web