[RFC][PATCH 4/7] perf/x86/intel: Remove redundant test from intel_pmu_lbr_add()

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	[RFC][PATCH 4/7] perf/x86/intel: Remove redundant test from intel_pmu_lbr_add()
Date	2016-07-08 16:10 +0200
Message-ID	<rSEDE-5P7-35@gated-at.bofh.it> (permalink)
References	<rSEDD-5P7-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

By the time we call pmu::add(), event->ctx must be set, and we
even already rely on this, so remove that test from
intel_pmu_lbr_add().

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 arch/x86/events/intel/lbr.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/arch/x86/events/intel/lbr.c
+++ b/arch/x86/events/intel/lbr.c
@@ -440,8 +440,7 @@ void intel_pmu_lbr_add(struct perf_event
 	}
 	cpuc->br_sel = event->hw.branch_reg.reg;
 
-	if (branch_user_callstack(cpuc->br_sel) && event->ctx &&
-					event->ctx->task_ctx_data) {
+	if (branch_user_callstack(cpuc->br_sel) && event->ctx->task_ctx_data) {
 		task_ctx = event->ctx->task_ctx_data;
 		task_ctx->lbr_callstack_users++;
 	}

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[RFC][PATCH 4/7] perf/x86/intel: Remove redundant test from intel_pmu_lbr_add() Peter Zijlstra <peterz@infradead.org> - 2016-07-08 16:10 +0200

csiph-web