Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439389 > unrolled thread
| Started by | Andi Shyti <andi.shyti@samsung.com> |
|---|---|
| First post | 2016-07-08 14:20 +0200 |
| Last post | 2016-07-08 15:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 4/4] spi: s3c64xx: restore removed comments Andi Shyti <andi.shyti@samsung.com> - 2016-07-08 14:20 +0200
Re: [PATCH 4/4] spi: s3c64xx: restore removed comments Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-08 15:00 +0200
| From | Andi Shyti <andi.shyti@samsung.com> |
|---|---|
| Date | 2016-07-08 14:20 +0200 |
| Subject | [PATCH 4/4] spi: s3c64xx: restore removed comments |
| Message-ID | <rSCVb-4Fq-9@gated-at.bofh.it> |
Patch a9e93e8 has erroneously removed some comments which are
important to understand why the bus frequency is multiplied by
two during the spi transfer.
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
drivers/spi/spi-s3c64xx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 1874bc5..d1fe100 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -639,6 +639,8 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
writel(val, regs + S3C64XX_SPI_MODE_CFG);
if (sdd->port_conf->clk_from_cmu) {
+ /* Configure Clock */
+ /* There is half-multiplier before the SPI */
clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
} else {
/* Configure Clock */
--
2.8.1
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-07-08 15:00 +0200 |
| Message-ID | <rSDxT-4TG-9@gated-at.bofh.it> |
| In reply to | #1439389 |
On 07/08/2016 02:18 PM, Andi Shyti wrote:
> Patch a9e93e8 has erroneously removed some comments which are
> important to understand why the bus frequency is multiplied by
> two during the spi transfer.
>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
> drivers/spi/spi-s3c64xx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 1874bc5..d1fe100 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -639,6 +639,8 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
> writel(val, regs + S3C64XX_SPI_MODE_CFG);
>
> if (sdd->port_conf->clk_from_cmu) {
> + /* Configure Clock */
> + /* There is half-multiplier before the SPI */
Not a kernel coding style comment. :) Either proper one or just skip the
"configure clock" as it is meaningless.
BR,
Krzysztof
> clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
> } else {
> /* Configure Clock */
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web