Re: [PATCH 4/4] spi: s3c64xx: restore removed comments

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] spi: s3c64xx: restore removed comments
Date	2016-07-08 15:00 +0200
Message-ID	<rSDxT-4TG-9@gated-at.bofh.it> (permalink)
References	<rSCVb-4Fq-11@gated-at.bofh.it> <rSCVb-4Fq-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/08/2016 02:18 PM, Andi Shyti wrote:
> Patch a9e93e8 has erroneously removed some comments which are
> important to understand why the bus frequency is multiplied by
> two during the spi transfer.
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
>  drivers/spi/spi-s3c64xx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 1874bc5..d1fe100 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -639,6 +639,8 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
>  	writel(val, regs + S3C64XX_SPI_MODE_CFG);
>  
>  	if (sdd->port_conf->clk_from_cmu) {
> +		/* Configure Clock */
> +		/* There is half-multiplier before the SPI */

Not a kernel coding style comment. :) Either proper one or just skip the
"configure clock" as it is meaningless.

BR,
Krzysztof

>  		clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
>  	} else {
>  		/* Configure Clock */
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] spi: s3c64xx: restore removed comments Andi Shyti <andi.shyti@samsung.com> - 2016-07-08 14:20 +0200
  Re: [PATCH 4/4] spi: s3c64xx: restore removed comments Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-08 15:00 +0200

csiph-web