Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436508 > unrolled thread
| Started by | John Crispin <john@phrozen.org> |
|---|---|
| First post | 2016-07-04 15:40 +0200 |
| Last post | 2016-07-05 09:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] net-next: mediatek: remove superfluous free_irq() call John Crispin <john@phrozen.org> - 2016-07-04 15:40 +0200
Re: [PATCH] net-next: mediatek: remove superfluous free_irq() call Arnd Bergmann <arnd@arndb.de> - 2016-07-04 15:50 +0200
Re: [PATCH] net-next: mediatek: remove superfluous free_irq() call David Miller <davem@davemloft.net> - 2016-07-05 09:00 +0200
| From | John Crispin <john@phrozen.org> |
|---|---|
| Date | 2016-07-04 15:40 +0200 |
| Subject | [PATCH] net-next: mediatek: remove superfluous free_irq() call |
| Message-ID | <rRcgp-6ag-5@gated-at.bofh.it> |
Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping")
adds handling for irq 1 and 2 to the uninit function but did not remove
irq 0 which is not used since irq grouping was introduced. Fix this by
removing the superfluous call to free_irq().
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: John Crispin <john@phrozen.org>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index fbab9b2..682797e 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1492,7 +1492,6 @@ static void mtk_uninit(struct net_device *dev)
phy_disconnect(mac->phy_dev);
mtk_mdio_cleanup(eth);
mtk_irq_disable(eth, ~0);
- free_irq(eth->irq[0], dev);
free_irq(eth->irq[1], dev);
free_irq(eth->irq[2], dev);
}
--
1.7.10.4
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-04 15:50 +0200 |
| Message-ID | <rRcq5-6dI-3@gated-at.bofh.it> |
| In reply to | #1436508 |
On Monday, July 4, 2016 3:37:10 PM CEST John Crispin wrote:
> Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping")
> adds handling for irq 1 and 2 to the uninit function but did not remove
> irq 0 which is not used since irq grouping was introduced. Fix this by
> removing the superfluous call to free_irq().
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: John Crispin <john@phrozen.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the quick update!
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-07-05 09:00 +0200 |
| Message-ID | <rRsuS-7IG-29@gated-at.bofh.it> |
| In reply to | #1436508 |
From: John Crispin <john@phrozen.org>
Date: Mon, 4 Jul 2016 15:37:10 +0200
> Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping")
> adds handling for irq 1 and 2 to the uninit function but did not remove
> irq 0 which is not used since irq grouping was introduced. Fix this by
> removing the superfluous call to free_irq().
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: John Crispin <john@phrozen.org>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web