[PATCH] net-next: mediatek: remove superfluous free_irq() call

From	John Crispin <john@phrozen.org>
Newsgroups	linux.kernel
Subject	[PATCH] net-next: mediatek: remove superfluous free_irq() call
Date	2016-07-04 15:40 +0200
Message-ID	<rRcgp-6ag-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping")
adds handling for irq 1 and 2 to the uninit function but did not remove
irq 0 which is not used since irq grouping was introduced. Fix this by
removing the superfluous call to free_irq().

Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index fbab9b2..682797e 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1492,7 +1492,6 @@ static void mtk_uninit(struct net_device *dev)
 	phy_disconnect(mac->phy_dev);
 	mtk_mdio_cleanup(eth);
 	mtk_irq_disable(eth, ~0);
-	free_irq(eth->irq[0], dev);
 	free_irq(eth->irq[1], dev);
 	free_irq(eth->irq[2], dev);
 }
-- 
1.7.10.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net-next: mediatek: remove superfluous free_irq() call John Crispin <john@phrozen.org> - 2016-07-04 15:40 +0200
  Re: [PATCH] net-next: mediatek: remove superfluous free_irq() call Arnd Bergmann <arnd@arndb.de> - 2016-07-04 15:50 +0200
  Re: [PATCH] net-next: mediatek: remove superfluous free_irq() call David Miller <davem@davemloft.net> - 2016-07-05 09:00 +0200

csiph-web