Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1435118 > unrolled thread
| Started by | Andi Shyti <andi.shyti@samsung.com> |
|---|---|
| First post | 2016-07-01 10:20 +0200 |
| Last post | 2016-07-04 13:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT precompiler check Andi Shyti <andi.shyti@samsung.com> - 2016-07-01 10:20 +0200
Re: [PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT precompiler check Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-04 13:40 +0200
| From | Andi Shyti <andi.shyti@samsung.com> |
|---|---|
| Date | 2016-07-01 10:20 +0200 |
| Subject | [PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT precompiler check |
| Message-ID | <rQ1Q6-4fw-27@gated-at.bofh.it> |
There is no need to check in precompilation whether the ioctl is
compat or unlocked, depending on the configuration it will be
called the correct one.
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
drivers/media/rc/lirc_dev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
index d98a9f1..16cca46 100644
--- a/drivers/media/rc/lirc_dev.c
+++ b/drivers/media/rc/lirc_dev.c
@@ -150,9 +150,7 @@ static const struct file_operations lirc_dev_fops = {
.write = lirc_dev_fop_write,
.poll = lirc_dev_fop_poll,
.unlocked_ioctl = lirc_dev_fop_ioctl,
-#ifdef CONFIG_COMPAT
.compat_ioctl = lirc_dev_fop_ioctl,
-#endif
.open = lirc_dev_fop_open,
.release = lirc_dev_fop_close,
.llseek = noop_llseek,
--
2.8.1
[toc] | [next] | [standalone]
| From | Hans Verkuil <hverkuil@xs4all.nl> |
|---|---|
| Date | 2016-07-04 13:40 +0200 |
| Subject | Re: [PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT precompiler check |
| Message-ID | <rRaoi-52n-27@gated-at.bofh.it> |
| In reply to | #1435118 |
On 07/01/2016 10:01 AM, Andi Shyti wrote:
> There is no need to check in precompilation whether the ioctl is
> compat or unlocked, depending on the configuration it will be
> called the correct one.
>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
> drivers/media/rc/lirc_dev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
> index d98a9f1..16cca46 100644
> --- a/drivers/media/rc/lirc_dev.c
> +++ b/drivers/media/rc/lirc_dev.c
> @@ -150,9 +150,7 @@ static const struct file_operations lirc_dev_fops = {
> .write = lirc_dev_fop_write,
> .poll = lirc_dev_fop_poll,
> .unlocked_ioctl = lirc_dev_fop_ioctl,
> -#ifdef CONFIG_COMPAT
> .compat_ioctl = lirc_dev_fop_ioctl,
> -#endif
I'd say this compat_ioctl can be dropped completely since there is nothing to do.
Regards,
Hans
> .open = lirc_dev_fop_open,
> .release = lirc_dev_fop_close,
> .llseek = noop_llseek,
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web