Re: [PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT precompiler check

From	Hans Verkuil <hverkuil@xs4all.nl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT precompiler check
Date	2016-07-04 13:40 +0200
Message-ID	<rRaoi-52n-27@gated-at.bofh.it> (permalink)
References	<rQ1Gp-4bf-7@gated-at.bofh.it> <rQ1Q6-4fw-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/01/2016 10:01 AM, Andi Shyti wrote:
> There is no need to check in precompilation whether the ioctl is
> compat or unlocked, depending on the configuration it will be
> called the correct one.
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
>  drivers/media/rc/lirc_dev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
> index d98a9f1..16cca46 100644
> --- a/drivers/media/rc/lirc_dev.c
> +++ b/drivers/media/rc/lirc_dev.c
> @@ -150,9 +150,7 @@ static const struct file_operations lirc_dev_fops = {
>  	.write		= lirc_dev_fop_write,
>  	.poll		= lirc_dev_fop_poll,
>  	.unlocked_ioctl	= lirc_dev_fop_ioctl,
> -#ifdef CONFIG_COMPAT
>  	.compat_ioctl	= lirc_dev_fop_ioctl,
> -#endif

I'd say this compat_ioctl can be dropped completely since there is nothing to do.

Regards,

	Hans

>  	.open		= lirc_dev_fop_open,
>  	.release	= lirc_dev_fop_close,
>  	.llseek		= noop_llseek,
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT precompiler  check Andi Shyti <andi.shyti@samsung.com> - 2016-07-01 10:20 +0200
  Re: [PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT  precompiler check Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-04 13:40 +0200

csiph-web