Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1437683 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-07-06 14:50 +0200 |
| Last post | 2016-07-07 15:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] firmware: scpi: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-07-06 14:50 +0200
Re: [PATCH 2/2] firmware: scpi: add CONFIG_OF dependency Sudeep Holla <sudeep.holla@arm.com> - 2016-07-06 15:20 +0200
Re: [PATCH 2/2] firmware: scpi: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-07-07 15:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-06 14:50 +0200 |
| Subject | [PATCH 2/2] firmware: scpi: add CONFIG_OF dependency |
| Message-ID | <rRUr7-OO-1@gated-at.bofh.it> |
We get a harmless warning if the ARM_SCPI_POWER_DOMAIN driver is enabled
without CONFIG_OF during compile testing:
warning: (ARM_SCPI_POWER_DOMAIN) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can
replace the 'select' with a dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8bec4337ad40 ("firmware: scpi: add device power domain support using genpd")
---
drivers/firmware/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 541d3fb7ae43..0e22f241403b 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -29,10 +29,9 @@ config ARM_SCPI_PROTOCOL
config ARM_SCPI_POWER_DOMAIN
tristate "SCPI power domain driver"
- depends on ARM_SCPI_PROTOCOL || COMPILE_TEST
+ depends on ARM_SCPI_PROTOCOL || (COMPILE_TEST && OF)
default y
select PM_GENERIC_DOMAINS if PM
- select PM_GENERIC_DOMAINS_OF if PM
help
This enables support for the SCPI power domains which can be
enabled or disabled via the SCP firmware
--
2.9.0
[toc] | [next] | [standalone]
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Date | 2016-07-06 15:20 +0200 |
| Message-ID | <rRUUa-1e4-27@gated-at.bofh.it> |
| In reply to | #1437683 |
Hi Arnd, On 06/07/16 13:49, Arnd Bergmann wrote: > We get a harmless warning if the ARM_SCPI_POWER_DOMAIN driver is enabled > without CONFIG_OF during compile testing: > > warning: (ARM_SCPI_POWER_DOMAIN) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF) > > There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can > replace the 'select' with a dependency. > Thanks for spotting this and fixing. Do you plan to take this directly ? If so, Acked-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-07 15:00 +0200 |
| Message-ID | <rSh4l-71b-19@gated-at.bofh.it> |
| In reply to | #1437704 |
On Wednesday, July 6, 2016 2:17:18 PM CEST Sudeep Holla wrote: > On 06/07/16 13:49, Arnd Bergmann wrote: > > We get a harmless warning if the ARM_SCPI_POWER_DOMAIN driver is enabled > > without CONFIG_OF during compile testing: > > > > warning: (ARM_SCPI_POWER_DOMAIN) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF) > > > > There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can > > replace the 'select' with a dependency. > > > > Thanks for spotting this and fixing. Do you plan to take this directly ? > If so, > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > Applied to next/drivers, thanks for the Ack Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web