[PATCH 2/2] firmware: scpi: add CONFIG_OF dependency

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] firmware: scpi: add CONFIG_OF dependency
Date	2016-07-06 14:50 +0200
Message-ID	<rRUr7-OO-1@gated-at.bofh.it> (permalink)
References	<rRUr7-OO-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

We get a harmless warning if the ARM_SCPI_POWER_DOMAIN driver is enabled
without CONFIG_OF during compile testing:

warning: (ARM_SCPI_POWER_DOMAIN) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)

There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can
replace the 'select' with a dependency.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8bec4337ad40 ("firmware: scpi: add device power domain support using genpd")
---
 drivers/firmware/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 541d3fb7ae43..0e22f241403b 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -29,10 +29,9 @@ config ARM_SCPI_PROTOCOL
 
 config ARM_SCPI_POWER_DOMAIN
 	tristate "SCPI power domain driver"
-	depends on ARM_SCPI_PROTOCOL || COMPILE_TEST
+	depends on ARM_SCPI_PROTOCOL || (COMPILE_TEST && OF)
 	default y
 	select PM_GENERIC_DOMAINS if PM
-	select PM_GENERIC_DOMAINS_OF if PM
 	help
 	  This enables support for the SCPI power domains which can be
 	  enabled or disabled via the SCP firmware
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] firmware: scpi: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-07-06 14:50 +0200
  Re: [PATCH 2/2] firmware: scpi: add CONFIG_OF dependency Sudeep Holla <sudeep.holla@arm.com> - 2016-07-06 15:20 +0200
    Re: [PATCH 2/2] firmware: scpi: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-07-07 15:00 +0200

csiph-web