Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1431175 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2016-06-25 19:30 +0200 |
| Last post | 2016-06-29 19:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [patch V4 27/31] serial: use parity32 in max3100 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-25 19:30 +0200
[patch V4 27/31] serial: use parity8 in max3100 zengzhaoxiu@163.com - 2016-06-29 17:20 +0200
Re: [patch V4 27/31] serial: use parity8 in max3100 Greg KH <gregkh@linuxfoundation.org> - 2016-06-29 18:50 +0200
[patch V4 27/31] serial: use parity8 in max3100 zengzhaoxiu@163.com - 2016-06-29 19:30 +0200
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-06-25 19:30 +0200 |
| Subject | Re: [patch V4 27/31] serial: use parity32 in max3100 |
| Message-ID | <rNZz4-8h4-9@gated-at.bofh.it> |
On Wed, May 11, 2016 at 05:23:07PM +0800, zengzhaoxiu@163.com wrote: > From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> > > Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/tty/serial/max3100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c > index 5c4c280..a0cc84a 100644 > --- a/drivers/tty/serial/max3100.c > +++ b/drivers/tty/serial/max3100.c > @@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c) > else > c &= 0xff; > > - parity = parity ^ (hweight8(c) & 1); > + parity ^= parity8(c); Your subject does not match the patch, and there is no changelog text so I can't take it :( Please fix up. greg k-h
[toc] | [next] | [standalone]
| From | zengzhaoxiu@163.com |
|---|---|
| Date | 2016-06-29 17:20 +0200 |
| Subject | [patch V4 27/31] serial: use parity8 in max3100 |
| Message-ID | <rPprs-5Ob-13@gated-at.bofh.it> |
| In reply to | #1431175 |
From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/tty/serial/max3100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c index 5c4c280..a0cc84a 100644 --- a/drivers/tty/serial/max3100.c +++ b/drivers/tty/serial/max3100.c @@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c) else c &= 0xff; - parity = parity ^ (hweight8(c) & 1); + parity ^= parity8(c); return parity; } -- 2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-06-29 18:50 +0200 |
| Subject | Re: [patch V4 27/31] serial: use parity8 in max3100 |
| Message-ID | <rPqQy-6AE-27@gated-at.bofh.it> |
| In reply to | #1433841 |
On Wed, Jun 29, 2016 at 10:57:08PM +0800, zengzhaoxiu@163.com wrote: > From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> > > Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> I acked this? I don't remember doing that... Again, I can't take patches without any changelog text, sorry. Please take my ack off of this patch. greg k-h
[toc] | [prev] | [next] | [standalone]
| From | zengzhaoxiu@163.com |
|---|---|
| Date | 2016-06-29 19:30 +0200 |
| Subject | [patch V4 27/31] serial: use parity8 in max3100 |
| Message-ID | <rPrtf-72Q-11@gated-at.bofh.it> |
| In reply to | #1433905 |
From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> Use parity8(c) instead "hweight8(c) & 1" to improve readability, and improve performance on some CPUs that without popcount support. Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> --- drivers/tty/serial/max3100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c index 5c4c280..a0cc84a 100644 --- a/drivers/tty/serial/max3100.c +++ b/drivers/tty/serial/max3100.c @@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c) else c &= 0xff; - parity = parity ^ (hweight8(c) & 1); + parity ^= parity8(c); return parity; } -- 2.7.4
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web