Re: [patch V4 27/31] serial: use parity32 in max3100

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [patch V4 27/31] serial: use parity32 in max3100
Date	2016-06-25 19:30 +0200
Message-ID	<rNZz4-8h4-9@gated-at.bofh.it> (permalink)
References	<rxxGP-4ls-49@gated-at.bofh.it> <rxyCU-5ns-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 11, 2016 at 05:23:07PM +0800, zengzhaoxiu@163.com wrote:
> From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
> 
> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/tty/serial/max3100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
> index 5c4c280..a0cc84a 100644
> --- a/drivers/tty/serial/max3100.c
> +++ b/drivers/tty/serial/max3100.c
> @@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c)
>  	else
>  		c &= 0xff;
>  
> -	parity = parity ^ (hweight8(c) & 1);
> +	parity ^= parity8(c);

Your subject does not match the patch, and there is no changelog text so
I can't take it :(

Please fix up.

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [patch V4 27/31] serial: use parity32 in max3100 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-25 19:30 +0200
  [patch V4 27/31] serial: use parity8 in max3100 zengzhaoxiu@163.com - 2016-06-29 17:20 +0200
    Re: [patch V4 27/31] serial: use parity8 in max3100 Greg KH <gregkh@linuxfoundation.org> - 2016-06-29 18:50 +0200
      [patch V4 27/31] serial: use parity8 in max3100 zengzhaoxiu@163.com - 2016-06-29 19:30 +0200

csiph-web